Skip to content

Commit 3e6af30

Browse files
sherif-olaboyekevwhitt-hee
authored andcommitted
TD-4884 Resolved git build error
1 parent fdc3bb6 commit 3e6af30

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

DigitalLearningSolutions.Web.Tests/Controllers/SupervisorController/SupervisorControllerTests.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,8 @@ public void Setup()
105105
emailService,
106106
candidateAssessmentDownloadFileService,
107107
clockUtility,
108-
pdfService
108+
pdfService,
109+
courseCategoriesService
109110
);
110111
controller.ControllerContext = new ControllerContext
111112
{ HttpContext = new DefaultHttpContext { User = user } };
@@ -158,6 +159,7 @@ public void ReviewDelegateSelfAssessment_Should_Return_View_With_Optional_Compet
158159
// Given
159160
int candidateAssessmentId = 1;
160161
int supervisorDelegateId = 2;
162+
int? adminIdCategoryId = 0;
161163
var superviseDelegate = SupervisorTagTestHelper.CreateDefaultSupervisorDelegateDetail();
162164
var delegateSelfAssessment = SupervisorTagTestHelper.CreateDefaultDelegateSelfAssessment();
163165
var appliedFilterViewModel = new List<AppliedFilterViewModel>();
@@ -187,7 +189,7 @@ public void ReviewDelegateSelfAssessment_Should_Return_View_With_Optional_Compet
187189

188190
A.CallTo(() => supervisorService.GetSupervisorDelegateDetailsById(supervisorDelegateId, AdminId, 0))
189191
.Returns(superviseDelegate);
190-
A.CallTo(() => supervisorService.GetSelfAssessmentByCandidateAssessmentId(candidateAssessmentId, AdminId))
192+
A.CallTo(() => supervisorService.GetSelfAssessmentByCandidateAssessmentId(candidateAssessmentId, AdminId, adminIdCategoryId))
191193
.Returns(delegateSelfAssessment);
192194
A.CallTo(() => selfAssessmentService.GetMostRecentResults(SelfAssessmentId, DelegateUserId))
193195
.Returns(competencies);

DigitalLearningSolutions.Web/Controllers/SupervisorController/Supervisor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ public IActionResult ReviewDelegateSelfAssessment(int supervisorDelegateId, int
376376
IsSupervisorResultsReviewed = delegateSelfAssessment.IsSupervisorResultsReviewed,
377377
SearchViewModel = searchModel,
378378
CandidateAssessmentId = candidateAssessmentId,
379-
ExportToExcelHide = delegateSelfAssessment.SupervisorRoleTitle.Contains("Assessor"),
379+
ExportToExcelHide = delegateSelfAssessment.SupervisorRoleTitle?.Contains("Assessor") ?? false,
380380
};
381381

382382
var flags = frameworkService.GetSelectedCompetencyFlagsByCompetecyIds(reviewedCompetencies.Select(c => c.Id).ToArray());

0 commit comments

Comments
 (0)