Skip to content

Commit 4b0adec

Browse files
authored
Merge pull request #3367 from TechnologyEnhancedLearning/Develop/Fix/TD-5548-competency-records-changed-order-message
TD-5548- Competency groups that have any competencies, were selected for old/new group comparison.
2 parents 8476491 + cf727ed commit 4b0adec

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

DigitalLearningSolutions.Web/Services/ImportCompetenciesFromFileService.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,13 @@ public ImportCompetenciesResult PreProcessCompetenciesTable(IXLWorkbook workbook
3737
var newCompetencyIds = competencyRows.Select(row => row.ID ?? 0).ToList();
3838
var existingIds = frameworkService.GetFrameworkCompetencyOrder(frameworkId, newCompetencyIds);
3939
var existingGroups = frameworkService
40-
.GetFrameworkCompetencyGroups(frameworkId)
40+
.GetFrameworkCompetencyGroups(frameworkId).Where(x => x.FrameworkCompetencies.Any()).ToList()
4141
.Select(row => row.Name)
4242
.Distinct()
4343
.ToList();
44-
var newGroups = competencyRows.Select(row => row.CompetencyGroup ?? "").Distinct().ToList();
44+
var newGroups = competencyRows.Select(row => row.CompetencyGroup)
45+
.Where(g => !string.IsNullOrEmpty(g))
46+
.Distinct().ToList();
4547
foreach (var competencyRow in competencyRows)
4648
{
4749
PreProcessCompetencyRow(competencyRow, newCompetencyIds, existingIds, existingGroups, newGroups);

0 commit comments

Comments
 (0)