Skip to content

Commit 545cf0c

Browse files
TD-3671 fixed enrolling from 'Tracking system-Manage Delegate' view doesn't appear on 'Current activities'
1 parent c3f0dd9 commit 545cf0c

File tree

7 files changed

+30
-18
lines changed

7 files changed

+30
-18
lines changed

DigitalLearningSolutions.Data/DataServices/ProgressDataService.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public interface IProgressDataService
1515
{
1616
IEnumerable<Progress> GetDelegateProgressForCourse(int delegateId, int customisationId);
1717

18-
void UpdateProgressSupervisorAndCompleteByDate(int progressId, int supervisorAdminId, DateTime? completeByDate);
18+
void UpdateProgressSupervisorAndCompleteByDate(int progressId, int supervisorAdminId, DateTime? completeByDate,DateTime submittedTime);
1919

2020
int CreateNewDelegateProgress(
2121
int delegateId,
@@ -143,15 +143,16 @@ FROM Progress
143143
public void UpdateProgressSupervisorAndCompleteByDate(
144144
int progressId,
145145
int supervisorAdminId,
146-
DateTime? completeByDate
146+
DateTime? completeByDate, DateTime submittedTime
147147
)
148148
{
149149
connection.Execute(
150150
@"UPDATE Progress SET
151151
SupervisorAdminID = @supervisorAdminId,
152-
CompleteByDate = @completeByDate
152+
CompleteByDate = @completeByDate,
153+
SubmittedTime = @submittedTime
153154
WHERE ProgressID = @progressId",
154-
new { progressId, supervisorAdminId, completeByDate }
155+
new { progressId, supervisorAdminId, completeByDate, submittedTime }
155156
);
156157
}
157158

DigitalLearningSolutions.Web.Tests/Services/GroupServiceTests/GroupsServiceEnrolDelegateTests.cs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,8 @@ public void EnrolDelegateOnGroupCourses_updates_existing_progress_record()
348348
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(
349349
reusableProgressRecord.ProgressId,
350350
A<int>._,
351-
A<DateTime?>._
351+
A<DateTime?>._,
352+
A<DateTime>._
352353
)
353354
).MustHaveHappened();
354355
}
@@ -384,7 +385,8 @@ public void
384385
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(
385386
reusableProgressRecord.ProgressId,
386387
reusableProgressRecord.SupervisorAdminId,
387-
A<DateTime?>._
388+
A<DateTime?>._,
389+
A<DateTime>._
388390
)
389391
).MustHaveHappened();
390392
}
@@ -420,7 +422,8 @@ public void EnrolDelegateOnGroupCourses_update_uses_course_supervisor_id_if_cour
420422
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(
421423
reusableProgressRecord.ProgressId,
422424
supervisorId,
423-
A<DateTime?>._
425+
A<DateTime?>._,
426+
A<DateTime>._
424427
)
425428
).MustHaveHappened();
426429
}
@@ -456,7 +459,8 @@ public void
456459
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(
457460
reusableProgressRecord.ProgressId,
458461
A<int>._,
459-
null
462+
null,
463+
A<DateTime>._
460464
)
461465
).MustHaveHappened();
462466
}
@@ -494,7 +498,8 @@ public void
494498
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(
495499
reusableProgressRecord.ProgressId,
496500
A<int>._,
497-
expectedFutureDate
501+
expectedFutureDate,
502+
A<DateTime>._
498503
)
499504
).MustHaveHappened();
500505
}

DigitalLearningSolutions.Web.Tests/Services/GroupServiceTests/GroupsServiceTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ private void DelegateMustNotHaveBeenAddedToAGroup()
721721
private void DelegateProgressRecordMustNotHaveBeenUpdated()
722722
{
723723
A.CallTo(
724-
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(A<int>._, A<int>._, A<DateTime?>._)
724+
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(A<int>._, A<int>._, A<DateTime?>._, A<DateTime>._)
725725
).MustNotHaveHappened();
726726
}
727727

@@ -764,7 +764,7 @@ private void DatabaseModificationsDoNothing()
764764
A.CallTo(() => groupsDataService.AddDelegateToGroup(A<int>._, A<int>._, A<DateTime>._, A<int>._))
765765
.DoesNothing();
766766
A.CallTo(
767-
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(A<int>._, A<int>._, A<DateTime?>._)
767+
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(A<int>._, A<int>._, A<DateTime?>._, A<DateTime>._)
768768
).DoesNothing();
769769
A.CallTo(
770770
() => progressDataService.CreateNewDelegateProgress(

DigitalLearningSolutions.Web.Tests/Services/ProgressServiceTests.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public void UpdateSupervisor_does_not_update_records_if_new_supervisor_matches_c
5858

5959
// Then
6060
A.CallTo(
61-
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(A<int>._, A<int>._, A<DateTime?>._)
61+
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(A<int>._, A<int>._, A<DateTime?>._, A<DateTime>._)
6262
).MustNotHaveHappened();
6363
A.CallTo(
6464
() => progressDataService.ClearAspProgressVerificationRequest(A<int>._)
@@ -83,7 +83,8 @@ public void UpdateSupervisor_updates_records_if_new_supervisor_does_not_match_cu
8383
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(
8484
progressId,
8585
newSupervisorId,
86-
A<DateTime?>._
86+
A<DateTime?>._,
87+
A<DateTime>._
8788
)
8889
).MustHaveHappened();
8990
A.CallTo(
@@ -105,7 +106,7 @@ public void UpdateSupervisor_sets_supervisor_id_to_0_if_new_supervisor_is_null()
105106

106107
// Then
107108
A.CallTo(
108-
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(progressId, 0, A<DateTime?>._)
109+
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(progressId, 0, A<DateTime?>._, A<DateTime>._)
109110
).MustHaveHappened();
110111
A.CallTo(
111112
() => progressDataService.ClearAspProgressVerificationRequest(progressId)
@@ -122,7 +123,7 @@ public void UpdateSupervisor_throws_exception_if_no_progress_record_found()
122123
// Then
123124
Assert.Throws<ProgressNotFoundException>(() => progressService.UpdateSupervisor(progressId, null));
124125
A.CallTo(
125-
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(A<int>._, A<int>._, A<DateTime?>._)
126+
() => progressDataService.UpdateProgressSupervisorAndCompleteByDate(A<int>._, A<int>._, A<DateTime?>._, A<DateTime>._)
126127
).MustNotHaveHappened();
127128
A.CallTo(
128129
() => progressDataService.ClearAspProgressVerificationRequest(A<int>._)

DigitalLearningSolutions.Web/Services/EnrolService.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ public void EnrolDelegateOnCourse(int delegateId, int customisationId, int custo
102102
progressDataService.UpdateProgressSupervisorAndCompleteByDate(
103103
progressRecord.ProgressId,
104104
supervisorAdminId ?? 0,
105-
completeByDate
105+
completeByDate,
106+
clockUtility.UtcNow
106107
);
107108
}
108109
}

DigitalLearningSolutions.Web/Services/GroupsService.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -730,7 +730,9 @@ IEnumerable<NotificationPreference> delegateNotificationPreferences
730730
progressDataService.UpdateProgressSupervisorAndCompleteByDate(
731731
progressRecord.ProgressId,
732732
updatedSupervisorAdminId,
733-
completeByDate
733+
completeByDate,
734+
clockUtility.UtcNow
735+
734736
);
735737
}
736738
}

DigitalLearningSolutions.Web/Services/ProgressService.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,9 @@ public void UpdateSupervisor(int progressId, int? newSupervisorId)
105105
progressDataService.UpdateProgressSupervisorAndCompleteByDate(
106106
progressId,
107107
supervisorId,
108-
courseInfo.CompleteBy
108+
courseInfo.CompleteBy,
109+
clockUtility.UtcNow
110+
109111
);
110112

111113
progressDataService.ClearAspProgressVerificationRequest(progressId);

0 commit comments

Comments
 (0)