TD-4169 Framework Contributor Permission Not Working

rshrirohit · rshrirohit · commit 58b567bed904 · 2025-01-28T22:07:56.000Z
diff --git a/DigitalLearningSolutions.Data/DataServices/FrameworkDataService.cs b/DigitalLearningSolutions.Data/DataServices/FrameworkDataService.cs
@@ -1824,7 +1824,7 @@ FROM   Competencies AS C INNER JOIN
         public int GetAdminUserRoleForFrameworkId(int adminId, int frameworkId)
         {
             return (int)connection.ExecuteScalar(
-                @"SELECT CASE WHEN FW.OwnerAdminID = @adminId THEN 3 WHEN fwc.CanModify = 1 THEN 2 WHEN fwc.CanModify = 0 THEN 1 ELSE 0 END AS UserRole
+                @"SELECT MAX (CASE WHEN FW.OwnerAdminID = @adminId THEN 3 WHEN fwc.CanModify = 1 THEN 2 WHEN fwc.CanModify = 0 THEN 1 ELSE 0 END) AS UserRole
                 FROM Frameworks AS FW LEFT OUTER JOIN
                 FrameworkCollaborators AS fwc ON fwc.FrameworkID = FW.ID AND fwc.AdminID = @adminId
                 WHERE FW.ID = @frameworkId",

Original file line number	Diff line number	Diff line change
`@@ -1824,7 +1824,7 @@ FROM Competencies AS C INNER JOIN`
`1824`	`1824`	`public int GetAdminUserRoleForFrameworkId(int adminId, int frameworkId)`
`1825`	`1825`	`{`
`1826`	`1826`	`return (int)connection.ExecuteScalar(`
`1827`		`- @"SELECT CASE WHEN FW.OwnerAdminID = @adminId THEN 3 WHEN fwc.CanModify = 1 THEN 2 WHEN fwc.CanModify = 0 THEN 1 ELSE 0 END AS UserRole`
	`1827`	`+ @"SELECT MAX (CASE WHEN FW.OwnerAdminID = @adminId THEN 3 WHEN fwc.CanModify = 1 THEN 2 WHEN fwc.CanModify = 0 THEN 1 ELSE 0 END) AS UserRole`
`1828`	`1828`	`FROM Frameworks AS FW LEFT OUTER JOIN`
`1829`	`1829`	`FrameworkCollaborators AS fwc ON fwc.FrameworkID = FW.ID AND fwc.AdminID = @adminId`
`1830`	`1830`	`WHERE FW.ID = @frameworkId",`