Skip to content

Commit 61c9136

Browse files
authored
Merge pull request #3291 from TechnologyEnhancedLearning/Develop/Fix/TD-5667-trimming-trailing-leading-spaces
TD-5667-Competency group name and competency name has been trimmed.
2 parents ab8b9f9 + fbe2e26 commit 61c9136

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

DigitalLearningSolutions.Web/Controllers/FrameworksController/Competencies.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ public IActionResult AddEditFrameworkCompetencyGroup(int frameworkId, Competency
6868
if (string.IsNullOrWhiteSpace(StringHelper.StripHtmlTags(competencyGroupBase?.Description))) { competencyGroupBase.Description = null; }
6969
if (competencyGroupBase.ID > 0)
7070
{
71-
frameworkService.UpdateFrameworkCompetencyGroup(frameworkCompetencyGroupId, competencyGroupBase.CompetencyGroupID, competencyGroupBase.Name, SanitizerHelper.SanitizeHtmlData
71+
frameworkService.UpdateFrameworkCompetencyGroup(frameworkCompetencyGroupId, competencyGroupBase.CompetencyGroupID, competencyGroupBase.Name.Trim(), SanitizerHelper.SanitizeHtmlData
7272
(competencyGroupBase.Description), adminId);
7373
return new RedirectResult(Url.Action("ViewFramework", new { tabname = "Structure", frameworkId }) + "#fcgroup-" + frameworkCompetencyGroupId.ToString());
7474
}
75-
var newCompetencyGroupId = frameworkService.InsertCompetencyGroup(competencyGroupBase.Name, SanitizerHelper.SanitizeHtmlData(competencyGroupBase.Description), adminId, frameworkId);
75+
var newCompetencyGroupId = frameworkService.InsertCompetencyGroup(competencyGroupBase.Name.Trim(), SanitizerHelper.SanitizeHtmlData(competencyGroupBase.Description), adminId, frameworkId);
7676
if (newCompetencyGroupId > 0)
7777
{
7878
var newFrameworkCompetencyGroupId = frameworkService.InsertFrameworkCompetencyGroup(newCompetencyGroupId, frameworkId, adminId);
@@ -169,7 +169,7 @@ public IActionResult AddEditFrameworkCompetency(int frameworkId, FrameworkCompet
169169
{
170170

171171

172-
frameworkService.UpdateFrameworkCompetency(frameworkCompetencyId, frameworkCompetency.Name, frameworkCompetency.Description, adminId);
172+
frameworkService.UpdateFrameworkCompetency(frameworkCompetencyId, frameworkCompetency.Name.Trim(), frameworkCompetency.Description, adminId);
173173
frameworkService.UpdateCompetencyFlags(frameworkId, frameworkCompetency.CompetencyID, selectedFlagIds);
174174
return new RedirectResult(Url.Action("ViewFramework", new { tabname = "Structure", frameworkId, frameworkCompetencyGroupId, frameworkCompetencyId }) + "#fc-" + frameworkCompetencyId.ToString());
175175
}
@@ -216,7 +216,7 @@ public IActionResult AddDuplicateCompetency(int frameworkId, string competencyNa
216216

217217
private IActionResult SaveCompetency(int adminId, int frameworkId, FrameworkCompetency frameworkCompetency, int frameworkCompetencyId, int? frameworkCompetencyGroupId, int[]? selectedFlagIds)
218218
{
219-
var newCompetencyId = frameworkService.InsertCompetency(frameworkCompetency.Name, frameworkCompetency.Description, adminId);
219+
var newCompetencyId = frameworkService.InsertCompetency(frameworkCompetency.Name.Trim(), frameworkCompetency.Description, adminId);
220220
if (newCompetencyId > 0)
221221
{
222222
var newFrameworkCompetencyId = frameworkService.InsertFrameworkCompetency(newCompetencyId, frameworkCompetencyGroupId, adminId, frameworkId);

DigitalLearningSolutions.Web/Services/FrameworkService.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -603,12 +603,12 @@ public int InsertComment(int frameworkId, int adminId, string comment, int? repl
603603

604604
public int InsertCompetency(string name, string? description, int adminId, bool alwaysShowDescription = false)
605605
{
606-
return frameworkDataService.InsertCompetency(name, description, adminId, alwaysShowDescription);
606+
return frameworkDataService.InsertCompetency(name.Trim(), description, adminId, alwaysShowDescription);
607607
}
608608

609609
public int InsertCompetencyGroup(string groupName, string? groupDescription, int adminId, int? frameworkId)
610610
{
611-
return frameworkDataService.InsertCompetencyGroup(groupName, groupDescription, adminId, frameworkId);
611+
return frameworkDataService.InsertCompetencyGroup(groupName.Trim(), groupDescription, adminId, frameworkId);
612612
}
613613

614614
public int InsertFrameworkCompetency(int competencyId, int? frameworkCompetencyGroupID, int adminId, int frameworkId, bool addDefaultQuestions = true)
@@ -683,12 +683,12 @@ public int UpdateCompetencyFlags(int frameworkId, int competencyId, int[] select
683683

684684
public void UpdateFrameworkCompetency(int frameworkCompetencyId, string name, string? description, int adminId, bool? alwaysShowDescription)
685685
{
686-
frameworkDataService.UpdateFrameworkCompetency(frameworkCompetencyId, name, description, adminId, alwaysShowDescription);
686+
frameworkDataService.UpdateFrameworkCompetency(frameworkCompetencyId, name.Trim(), description, adminId, alwaysShowDescription);
687687
}
688688

689689
public bool UpdateFrameworkCompetencyGroup(int frameworkCompetencyGroupId, int competencyGroupId, string name, string? description, int adminId)
690690
{
691-
return frameworkDataService.UpdateFrameworkCompetencyGroup(frameworkCompetencyGroupId, competencyGroupId, name, description, adminId);
691+
return frameworkDataService.UpdateFrameworkCompetencyGroup(frameworkCompetencyGroupId, competencyGroupId, name.Trim(), description, adminId);
692692
}
693693

694694
public void UpdateFrameworkConfig(int frameworkId, int adminId, string? frameworkConfig)

0 commit comments

Comments
 (0)