Skip to content

Commit 6ae3e59

Browse files
committed
TD-483 Adds select linked framework source form validation
1 parent dfbaebe commit 6ae3e59

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

DigitalLearningSolutions.Web/Controllers/CompetencyAssessmentsController/CompetencyAssessments.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -529,16 +529,21 @@ public IActionResult AddCompetenciesSelectFramework(int competencyAssessmentId)
529529
}
530530
[HttpPost]
531531
[Route("/CompetencyAssessments/{competencyAssessmentId}/Competencies/Add/SelectFramework")]
532-
public IActionResult AddCompetenciesSelectFramework(AddCompetenciesSelectFrameworkFormData model)
532+
public IActionResult AddCompetenciesSelectFramework(AddCompetenciesSelectFrameworkFormData formdata)
533533
{
534534
if (!ModelState.IsValid)
535535
{
536-
var linkedFrameworks = competencyAssessmentService.GetLinkedFrameworksForCompetencyAssessment(model.ID);
536+
var competencyAssessmentId = formdata.ID;
537+
var linkedFrameworks = competencyAssessmentService.GetLinkedFrameworksForCompetencyAssessment(competencyAssessmentId);
538+
var adminId = GetAdminID();
539+
var competencyAssessmentBase = competencyAssessmentService.GetCompetencyAssessmentBaseById(competencyAssessmentId, adminId);
540+
var model = new AddCompetenciesSelectFrameworkViewModel(competencyAssessmentBase, linkedFrameworks);
541+
model.FrameworkId = formdata.FrameworkId;
537542
return View("AddCompetenciesSelectFramework", model);
538543
}
539544
else
540545
{
541-
return RedirectToAction("AddCompetencies", new { competencyAssessmentId = model.ID, frameworkId = model.FrameworkId });
546+
return RedirectToAction("AddCompetencies", new { competencyAssessmentId = formdata.ID, frameworkId = formdata.FrameworkId });
542547
}
543548
}
544549
[Route("/CompetencyAssessments/{competencyAssessmentId}/Competencies/Add/{frameworkId}")]

DigitalLearningSolutions.Web/ViewModels/CompetencyAssessments/AddCompetenciesSelectFrameworkFormData.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
using System.ComponentModel.DataAnnotations;
44
public class AddCompetenciesSelectFrameworkFormData
55
{
6-
[Required]
76
public int ID { get; set; }
8-
public int FrameworkId { get; set; }
7+
[Required(ErrorMessage = "Select a linked framework")]
8+
public int? FrameworkId { get; set; }
99
}
1010
}

DigitalLearningSolutions.Web/ViewModels/CompetencyAssessments/SelectFrameworkSourcesFormData.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
using System.ComponentModel.DataAnnotations;
44
public class SelectFrameworkSourcesFormData
55
{
6-
[Required]
6+
[Required(ErrorMessage = "Select a framework")]
77
public int FrameworkId { get; set; }
88
public int CompetencyAssessmentId { get; set; }
99
public bool? TaskStatus { get; set; }

DigitalLearningSolutions.Web/Views/CompetencyAssessments/AddCompetenciesSelectFramework.cshtml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
}
2424
<h1>Select Framework Source</h1>
2525
<form method="post">
26+
@if (!ViewData.ModelState.IsValid)
27+
{
28+
<partial name="_ErrorSummary" />
29+
}
2630
<div class="nhsuk-form-group">
2731

2832
<fieldset class="nhsuk-fieldset">
@@ -43,6 +47,7 @@
4347
}
4448
</div>
4549
</fieldset>
50+
<span nhs-validation-for="FrameworkId"></span>
4651
</div>
4752
<input type="hidden" asp-for="@Model.ID" />
4853
<button type="submit" class="nhsuk-button">Next</button>

0 commit comments

Comments
 (0)