TD-5153 checks for existence of file before trying to delete to prevent error on cancel

kevwhitt-hee · kevwhitt-hee · commit 6e3b878ab89e · 2025-03-12T08:39:52.000Z
diff --git a/DigitalLearningSolutions.Web/Controllers/FrameworksController/ImportCompetencies.cs b/DigitalLearningSolutions.Web/Controllers/FrameworksController/ImportCompetencies.cs
@@ -267,7 +267,10 @@ public IActionResult CancelImport()
         {
             var data = GetBulkUploadData();
             var frameworkId = data.FrameworkId;
-            FileHelper.DeleteFile(webHostEnvironment, data.CompetenciesFileName);
+            if (!string.IsNullOrWhiteSpace(data.CompetenciesFileName))
+            {
+                FileHelper.DeleteFile(webHostEnvironment, data.CompetenciesFileName);
+            }
             TempData.Clear();
             return RedirectToAction("ViewFramework", new { frameworkId, tabname = "Structure" });
         }

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,10 @@ public IActionResult CancelImport()`
`267`	`267`	`{`
`268`	`268`	`var data = GetBulkUploadData();`
`269`	`269`	`var frameworkId = data.FrameworkId;`
`270`		`- FileHelper.DeleteFile(webHostEnvironment, data.CompetenciesFileName);`
	`270`	`+ if (!string.IsNullOrWhiteSpace(data.CompetenciesFileName))`
	`271`	`+ {`
	`272`	`+ FileHelper.DeleteFile(webHostEnvironment, data.CompetenciesFileName);`
	`273`	`+ }`
`271`	`274`	`TempData.Clear();`
`272`	`275`	`return RedirectToAction("ViewFramework", new { frameworkId, tabname = "Structure" });`
`273`	`276`	`}`