Skip to content

Commit 7082f24

Browse files
Auldrin-Possakevwhitt-hee
authored andcommitted
TD-4975-Todo items for requested signoffs/confirmation are filtered by admin category
1 parent 5e43819 commit 7082f24

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

DigitalLearningSolutions.Data/DataServices/SupervisorDataService.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -643,8 +643,11 @@ public IEnumerable<SupervisorDashboardToDoItem> GetSupervisorDashboardToDoItemsF
643643
SelfAssessments AS sa ON ca.SelfAssessmentID = sa.ID INNER JOIN
644644
SupervisorDelegates AS sd ON cas.SupervisorDelegateId = sd.ID INNER JOIN
645645
CandidateAssessmentSupervisorVerifications AS casv ON cas.ID = casv.CandidateAssessmentSupervisorID INNER JOIN
646-
Users AS u ON ca.DelegateUserID = u.ID
647-
WHERE (sd.SupervisorAdminID = @adminId) AND (casv.Verified IS NULL) AND (cas.Removed IS NULL) AND (sd.Removed IS NULL)", new { adminId }
646+
Users AS u ON ca.DelegateUserID = u.ID INNER JOIN
647+
AdminAccounts As aa ON sd.SupervisorAdminID = aa.ID
648+
WHERE (sd.SupervisorAdminID = @adminId) AND (casv.Verified IS NULL) AND (cas.Removed IS NULL)
649+
AND (sd.Removed IS NULL)
650+
AND (aa.CategoryID is null or sa.CategoryID = aa.CategoryID)", new { adminId }
648651
);
649652
}
650653
public IEnumerable<SupervisorDashboardToDoItem> GetSupervisorDashboardToDoItemsForRequestedReviews(int adminId)
@@ -662,8 +665,10 @@ public IEnumerable<SupervisorDashboardToDoItem> GetSupervisorDashboardToDoItemsF
662665
SELECT TOP 1 sar2.DateTime
663666
FROM SelfAssessmentResults AS sar2
664667
WHERE sar2.ID = sar.ID AND sar2.SelfAssessmentID = sar.SelfAssessmentID AND sar2.CompetencyID = co.ID AND sar2.Result != 0 ORDER BY sar2.ID DESC
665-
)
668+
) INNER JOIN
669+
AdminAccounts AS aa ON sd.SupervisorAdminID = aa.ID
666670
WHERE (sd.SupervisorAdminID = @adminId) AND (cas.Removed IS NULL) AND (sasv.Verified IS NULL) AND (sd.Removed IS NULL)
671+
AND (aa.CategoryID is null or sa.CategoryID = aa.CategoryID)
667672
GROUP BY sa.ID, ca.ID, sd.ID, u.FirstName, u.LastName, sa.Name,cast(sasv.Requested as date)", new { adminId }
668673
);
669674
}

0 commit comments

Comments
 (0)