Skip to content

Commit 88d3659

Browse files
authored
Merge pull request #3350 from TechnologyEnhancedLearning/Develop/Fix/TD-5884-DLS-and-centre-logo-appearing-close-together
TD-5884- Managed header div positions and CSS classes to align the logo.
2 parents a1d4f31 + aa7cb46 commit 88d3659

File tree

3 files changed

+24
-16
lines changed

3 files changed

+24
-16
lines changed

DigitalLearningSolutions.Web/Styles/nhsuk.scss

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ body:not(.js-enabled) {
4949

5050
/* .nhsuk-header--transactional brought from live design-system, not in current implentation */
5151
.nhsuk-header--transactional {
52-
.nhsuk-header__container {
53-
justify-content: normal;
54-
}
5552

5653
.nhsuk-header__link {
5754
display: block;
@@ -137,7 +134,18 @@ input[type=file].nhsuk-input--error {
137134
text-align: center;
138135
}
139136

137+
.nhsuk-header__logo {
138+
display: flex;
139+
justify-content: space-between;
140+
}
140141

142+
@media (max-width: 600px) {
143+
.nhsuk-header__transactional--logo {
144+
flex-direction: column;
145+
align-items: flex-start;
146+
gap: 4px;
147+
}
148+
}
141149

142150
/*
143151
styles/index.scss has the following nhsuk dependancies - FGC 2/6/25

DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/_Layout.cshtml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@
6767
<image src="https://assets.nhs.uk/images/nhs-logo.png" width="40" height="16" xlink:href=""></image>
6868
</svg>
6969
</a>
70-
</div>
71-
<div class="nhsuk-header__transactional-service-name">
72-
<a class="nhsuk-header__transactional-service-name--link" href="/">@ViewData["SelfAssessmentTitle"]</a>
73-
<sup class="header-beta">Beta</sup>
70+
<div class="nhsuk-header__transactional-service-name">
71+
<a class="nhsuk-header__transactional-service-name--link" href="/">@ViewData["SelfAssessmentTitle"]</a>
72+
<sup class="header-beta">Beta</sup>
73+
</div>
7474
</div>
7575
</div>
7676
<feature name="@(FeatureFlags.UserFeedbackBar)">

DigitalLearningSolutions.Web/Views/Shared/_Layout.cshtml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
}
8383

8484
<div class="nhsuk-header__container">
85-
<div class="nhsuk-header__logo nhsuk-header__transactional--logo">
85+
<div class="nhsuk-header__transactional--logo nhsuk-header__logo">
8686
<a class="nhsuk-header__link"
8787
href="@(ViewData[LayoutViewDataKeys.HeaderPath] ?? Configuration["AppRootPath"] + "/Home")"
8888
aria-label="NHS Digital Learning Solutions - @(ViewData[LayoutViewDataKeys.HeaderPathName] ?? "Landing Page")">
@@ -93,16 +93,16 @@
9393
<image src="https://assets.nhs.uk/images/nhs-logo.png" width="40" height="16" xlink:href=""></image>
9494
</svg>
9595
</a>
96-
</div>
97-
<div class="nhsuk-header__transactional-service-name">
98-
<a class="nhsuk-header__transactional-service-name--link" href="@(ViewData[LayoutViewDataKeys.HeaderPath] ?? Configuration["AppRootPath"] + "/Home")">@(ViewData[LayoutViewDataKeys.HeaderPrefix] ?? "Digital Learning Solutions ")@(headerExtension)</a>
99-
@if (ViewData[LayoutViewDataKeys.Application] != null)
100-
{
101-
if (ViewData[LayoutViewDataKeys.Application].ToString() == "Framework Service" | ViewData[LayoutViewDataKeys.Application].ToString() == "Supervise")
96+
<div class="nhsuk-header__transactional-service-name">
97+
<a class="nhsuk-header__transactional-service-name--link" href="@(ViewData[LayoutViewDataKeys.HeaderPath] ?? Configuration["AppRootPath"] + "/Home")">@(ViewData[LayoutViewDataKeys.HeaderPrefix] ?? "Digital Learning Solutions ")@(headerExtension)</a>
98+
@if (ViewData[LayoutViewDataKeys.Application] != null)
10299
{
103-
<sup class="header-beta header-beta--dark">Beta</sup>
100+
if (ViewData[LayoutViewDataKeys.Application].ToString() == "Framework Service" | ViewData[LayoutViewDataKeys.Application].ToString() == "Supervise")
101+
{
102+
<sup class="header-beta header-beta--dark">Beta</sup>
103+
}
104104
}
105-
}
105+
</div>
106106
</div>
107107
<vc:logo customisation-id="@((int?)ViewData[LayoutViewDataKeys.CustomisationIdForHeaderLogo])" />
108108
</div>

0 commit comments

Comments
 (0)