TD-5220 Fixes order comparison by adding Distinct() to linq

kevwhitt-hee · kevwhitt-hee · commit 92b6638a64e6 · 2025-04-16T14:27:47.000+01:00
diff --git a/DigitalLearningSolutions.Web/Services/ImportCompetenciesFromFileService.cs b/DigitalLearningSolutions.Web/Services/ImportCompetenciesFromFileService.cs
@@ -41,7 +41,7 @@ public ImportCompetenciesResult PreProcessCompetenciesTable(IXLWorkbook workbook
                 .Select(row => row.Name)
                 .Distinct()
                 .ToList();
-            var newGroups = competencyRows.Select(row => row.CompetencyGroup ?? "").ToList();
+            var newGroups = competencyRows.Select(row => row.CompetencyGroup ?? "").Distinct().ToList();
             foreach (var competencyRow in competencyRows)
             {
                 PreProcessCompetencyRow(competencyRow, newCompetencyIds, existingIds, existingGroups, newGroups);

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public ImportCompetenciesResult PreProcessCompetenciesTable(IXLWorkbook workbook`
`41`	`41`	`.Select(row => row.Name)`
`42`	`42`	`.Distinct()`
`43`	`43`	`.ToList();`
`44`		`- var newGroups = competencyRows.Select(row => row.CompetencyGroup ?? "").ToList();`
	`44`	`+ var newGroups = competencyRows.Select(row => row.CompetencyGroup ?? "").Distinct().ToList();`
`45`	`45`	`foreach (var competencyRow in competencyRows)`
`46`	`46`	`{`
`47`	`47`	`PreProcessCompetencyRow(competencyRow, newCompetencyIds, existingIds, existingGroups, newGroups);`