Merge pull request #2820 from TechnologyEnhancedLearning/revert-2796-Develop/Fix/TD-4634-Inactive-Unpublished-courses

Revert "TD-4634-Modified stored proc to return active and published status of courses."

Author: rshrirohit

DigitalLearningSolutions.Data.Migrations/202408231210_Alter_GetCompletedCoursesForCandidate_CourseActive.cs

@@ -418,10 +418,4 @@
   <data name="TD_4436_Alter_uspCreateProgressRecord_V3_Up" type="System.Resources.ResXFileRef, System.Windows.Forms">
     <value>..\Scripts\TD-4436-Alter_uspCreateProgressRecord_V3_Up.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
   </data>
-  <data name="TD_4634_Alter_GetCompletedCoursesForCandidate_DOWN" type="System.Resources.ResXFileRef, System.Windows.Forms">
-    <value>..\Scripts\TD-4634-Alter_GetCompletedCoursesForCandidate_DOWN.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
-  </data>
-  <data name="TD_4634_Alter_GetCompletedCoursesForCandidate_UP" type="System.Resources.ResXFileRef, System.Windows.Forms">
-    <value>..\Scripts\TD-4634-Alter_GetCompletedCoursesForCandidate_UP.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
-  </data>
 </root>

DigitalLearningSolutions.Data.Migrations/Properties/Resources.Designer.cs

@@ -12,7 +12,6 @@ public abstract class BaseLearningItem : BaseSearchableItem
         public bool IsSelfAssessment { get; set; }
         public bool SelfRegister { get; set; }
         public bool IncludesSignposting { get; set; }
-        public bool Active { get; set; }
         public int? CurrentVersion { get; set; }
         public override string SearchableName
         {

DigitalLearningSolutions.Data.Migrations/Properties/Resources.resx

@@ -8,6 +8,5 @@ public class CompletedLearningItem : StartedLearningItem
         public DateTime? Evaluated { get; set; }
         public DateTime? ArchivedDate { get; set; }
         public DateTime? RemovedDate { get; set; }
-        public bool Published { get; set; }
     }
 }

DigitalLearningSolutions.Data.Migrations/Scripts/TD-4634-Alter_GetCompletedCoursesForCandidate_DOWN.sql

@@ -14,7 +14,6 @@ protected BaseLearningItemViewModel(BaseLearningItem course)
             IsSelfAssessment = course.IsSelfAssessment;
             SelfRegister = course.SelfRegister;
             IncludesSignposting = course.IncludesSignposting;
-            Active = course.Active;
         }
 
         public string Name { get; set; }
@@ -25,6 +24,5 @@ protected BaseLearningItemViewModel(BaseLearningItem course)
         public bool IsSelfAssessment { get; }
         public bool SelfRegister { get; }
         public bool IncludesSignposting { get; }
-        public bool Active { get; }
     }
 }

DigitalLearningSolutions.Data.Migrations/Scripts/TD-4634-Alter_GetCompletedCoursesForCandidate_UP.sql

@@ -11,13 +11,11 @@ public CompletedLearningItemViewModel(CompletedLearningItem item) : base(item)
             EvaluatedDate = item.Evaluated;
             ArchivedDate = item.ArchivedDate;
             RemovedDate = item.RemovedDate;
-            Published = item.Published;
         }
 
         public DateTime CompletedDate { get; }
         public DateTime? EvaluatedDate { get; }
         public DateTime? ArchivedDate { get; }
         public DateTime? RemovedDate { get; }
-        public bool Published { get; }
     }
 }

DigitalLearningSolutions.Data/Models/BaseLearningItem.cs

@@ -31,7 +31,7 @@
     </details>
 
     <div class="flex-row">
-        @if (Model.ArchivedDate == null && Model.RemovedDate == null && Model.Active && Model.Published)
+        @if (Model.ArchivedDate == null && Model.RemovedDate == null)
         {
             <a class="nhsuk-button nhsuk-u-margin-bottom-2 nhsuk-u-margin-right-2"
                aria-describedby="@Model.Id-name"