Skip to content

Commit a7bb19c

Browse files
committed
Merge branch 'DLS-Release-v1.2.3' into UAT
2 parents cfa1054 + 8476491 commit a7bb19c

File tree

20 files changed

+919
-372
lines changed

20 files changed

+919
-372
lines changed
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
namespace DigitalLearningSolutions.Data.Migrations
2+
{
3+
using FluentMigrator;
4+
[Migration(202507221424)]
5+
public class AddNewColumnsInSelfAssessments : Migration
6+
{
7+
public override void Up()
8+
{
9+
Alter.Table("SelfAssessments")
10+
.AddColumn("RetirementDate").AsDateTime().Nullable()
11+
.AddColumn("EnrolmentCutoffDate").AsDateTime().Nullable()
12+
.AddColumn("RetirementReason").AsString(2000).Nullable();
13+
}
14+
15+
public override void Down()
16+
{
17+
Delete.Column("RetirementDate").FromTable("SelfAssessments");
18+
Delete.Column("EnrolmentCutoffDate").FromTable("SelfAssessments");
19+
Delete.Column("RetirementReason").FromTable("SelfAssessments");
20+
}
21+
}
22+
}
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
using FluentMigrator;
2+
3+
namespace DigitalLearningSolutions.Data.Migrations
4+
{
5+
[Migration(202507240953)]
6+
public class Alter_GetActivitiesForDelegateEnrolment_Retired_SA : Migration
7+
{
8+
public override void Up()
9+
{
10+
Execute.Sql(Properties.Resources.TD_5535_Alter_GetActivitiesForDelegateEnrolment_Up);
11+
}
12+
public override void Down()
13+
{
14+
Execute.Sql(Properties.Resources.TD_5535_Alter_GetActivitiesForDelegateEnrolment_Down);
15+
}
16+
}
17+
}
18+

DigitalLearningSolutions.Data.Migrations/Properties/Resources.Designer.cs

Lines changed: 64 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

DigitalLearningSolutions.Data.Migrations/Properties/Resources.resx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -499,4 +499,10 @@
499499
<data name="TD-5759_CreateOrAlterSelfAssessmentReportSPandTVF-Fix_UP" type="System.Resources.ResXFileRef, System.Windows.Forms">
500500
<value>..\Scripts\TD-5759_CreateOrAlterSelfAssessmentReportSPandTVF-Fix_UP.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-8</value>
501501
</data>
502+
<data name="TD_5535_Alter_GetActivitiesForDelegateEnrolment_Down" type="System.Resources.ResXFileRef, System.Windows.Forms">
503+
<value>..\Scripts\TD-5535-Alter_GetActivitiesForDelegateEnrolment_Down.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
504+
</data>
505+
<data name="TD_5535_Alter_GetActivitiesForDelegateEnrolment_Up" type="System.Resources.ResXFileRef, System.Windows.Forms">
506+
<value>..\Scripts\TD-5535-Alter_GetActivitiesForDelegateEnrolment_Up.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
507+
</data>
502508
</root>

DigitalLearningSolutions.Data/DataServices/SelfAssessmentDataService/CandidateAssessmentsDataService.cs

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -12,28 +12,31 @@ public IEnumerable<CurrentSelfAssessment> GetSelfAssessmentsForCandidate(int del
1212
{
1313
return connection.Query<CurrentSelfAssessment>(
1414
@"SELECT SelfAssessment.Id,
15-
SelfAssessment.Name,
16-
SelfAssessment.Description,
17-
SelfAssessment.IncludesSignposting,
18-
SelfAssessment.IncludeRequirementsFilters,
19-
SelfAssessment. IsSupervisorResultsReviewed,
20-
SelfAssessment.ReviewerCommentsLabel,
21-
SelfAssessment. Vocabulary,
22-
SelfAssessment. NumberOfCompetencies,
23-
SelfAssessment.StartedDate,
24-
SelfAssessment.LastAccessed,
25-
SelfAssessment.CompleteByDate,
26-
SelfAssessment.CandidateAssessmentId,
27-
SelfAssessment.UserBookmark,
28-
SelfAssessment.UnprocessedUpdates,
29-
SelfAssessment.LaunchCount,
30-
SelfAssessment. IsSelfAssessment,
31-
SelfAssessment.SubmittedDate,
32-
SelfAssessment. CentreName,
33-
SelfAssessment.EnrolmentMethodId,
34-
Signoff.SignedOff,
35-
Signoff.Verified,
36-
EnrolledByForename +' '+EnrolledBySurname AS EnrolledByFullName
15+
SelfAssessment.Name,
16+
SelfAssessment.Description,
17+
SelfAssessment.IncludesSignposting,
18+
SelfAssessment.IncludeRequirementsFilters,
19+
SelfAssessment. IsSupervisorResultsReviewed,
20+
SelfAssessment.ReviewerCommentsLabel,
21+
SelfAssessment. Vocabulary,
22+
SelfAssessment. NumberOfCompetencies,
23+
SelfAssessment.StartedDate,
24+
SelfAssessment.LastAccessed,
25+
SelfAssessment.CompleteByDate,
26+
SelfAssessment.CandidateAssessmentId,
27+
SelfAssessment.UserBookmark,
28+
SelfAssessment.UnprocessedUpdates,
29+
SelfAssessment.LaunchCount,
30+
SelfAssessment. IsSelfAssessment,
31+
SelfAssessment.SubmittedDate,
32+
SelfAssessment. CentreName,
33+
SelfAssessment.EnrolmentMethodId,
34+
SelfAssessment.RetirementDate,
35+
SelfAssessment.EnrolmentCutoffDate,
36+
SelfAssessment.RetirementReason,
37+
Signoff.SignedOff,
38+
Signoff.Verified,
39+
EnrolledByForename +' '+EnrolledBySurname AS EnrolledByFullName
3740
FROM (SELECT
3841
CA.SelfAssessmentID AS Id,
3942
SA.Name,
@@ -56,7 +59,10 @@ public IEnumerable<CurrentSelfAssessment> GetSelfAssessmentsForCandidate(int del
5659
CR.CentreName AS CentreName,
5760
CA.EnrolmentMethodId,
5861
uEnrolledBy.FirstName AS EnrolledByForename,
59-
uEnrolledBy.LastName AS EnrolledBySurname
62+
uEnrolledBy.LastName AS EnrolledBySurname,
63+
SA.RetirementDate,
64+
SA.EnrolmentCutoffDate,
65+
SA.RetirementReason
6066
FROM Centres AS CR INNER JOIN
6167
CandidateAssessments AS CA INNER JOIN
6268
SelfAssessments AS SA ON CA.SelfAssessmentID = SA.ID ON CR.CentreID = CA.CentreID INNER JOIN
@@ -71,7 +77,7 @@ Competencies AS C RIGHT OUTER JOIN
7177
AND (ISNULL(@adminIdCategoryID, 0) = 0 OR sa.CategoryID = @adminIdCategoryId)
7278
GROUP BY
7379
CA.SelfAssessmentID, SA.Name, SA.Description, SA.IncludesSignposting, SA.SupervisorResultsReview,
74-
SA.ReviewerCommentsLabel, SA.IncludeRequirementsFilters,
80+
SA.ReviewerCommentsLabel, SA.IncludeRequirementsFilters, SA.RetirementDate,SA.EnrolmentCutoffDate,SA.RetirementReason,
7581
COALESCE(SA.Vocabulary, 'Capability'), CA.StartedDate, CA.LastAccessed, CA.CompleteByDate,
7682
CA.ID,
7783
CA.UserBookmark, CA.UnprocessedUpdates, CA.LaunchCount, CA.SubmittedDate, CR.CentreName,CA.EnrolmentMethodId,

DigitalLearningSolutions.Data/DataServices/SelfAssessmentDataService/SelfAssessmentDataService.cs

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ public interface ISelfAssessmentDataService
1616
{
1717
//Self Assessments
1818
string? GetSelfAssessmentNameById(int selfAssessmentId);
19+
SelfAssessment? GetSelfAssessmentById(int selfAssessmentId);
20+
SelfAssessment GetSelfAssessmentRetirementDateById(int selfAssessmentId);
1921

2022
// CompetencyDataService
2123
IEnumerable<int> GetCompetencyIdsForSelfAssessment(int selfAssessmentId);
@@ -205,6 +207,67 @@ FROM SelfAssessments
205207
return name;
206208
}
207209

210+
public SelfAssessment? GetSelfAssessmentById(int selfAssessmentId)
211+
{
212+
return connection.Query<SelfAssessment?>(
213+
@"SELECT [ID]
214+
,[Name]
215+
,[Description]
216+
,[IncludesSignposting]
217+
,[BrandID]
218+
,[CreatedDate]
219+
,[CreatedByCentreID]
220+
,[CreatedByAdminID]
221+
,[ArchivedDate]
222+
,[ArchivedByAdminID]
223+
,[IncludeDevelopment]
224+
,[ParentSelfAssessmentID]
225+
,[NRPProfessionalGroupID]
226+
,[NRPSubGroupID]
227+
,[NRPRoleID]
228+
,[PublishStatusID]
229+
,[UpdatedByAdminID]
230+
,[National]
231+
,[Public]
232+
,[Archived]
233+
,[LastEdit]
234+
,[SupervisorSelfAssessmentReview]
235+
,[SupervisorResultsReview]
236+
,[RAGResults]
237+
,[LinearNavigation]
238+
,[CategoryID]
239+
,[UseDescriptionExpanders]
240+
,[ManageOptionalCompetenciesPrompt]
241+
,[Vocabulary]
242+
,[SignOffRequestorStatement]
243+
,[SignOffSupervisorStatement]
244+
,[QuestionLabel]
245+
,[DescriptionLabel]
246+
,[EnforceRoleRequirementsForSignOff]
247+
,[ReviewerCommentsLabel]
248+
,[ManageSupervisorsDescription]
249+
,[IncludeRequirementsFilters]
250+
,[MinimumOptionalCompetencies]
251+
,[RetirementDate]
252+
,[EnrolmentCutoffDate]
253+
,[RetirementReason]
254+
FROM SelfAssessments
255+
WHERE ID = @selfAssessmentId",
256+
new { selfAssessmentId }
257+
).SingleOrDefault();
258+
}
259+
public SelfAssessment GetSelfAssessmentRetirementDateById(int selfAssessmentId)
260+
{
261+
var date = connection.QueryFirstOrDefault<SelfAssessment>(
262+
@"SELECT Id,Name,[RetirementDate]
263+
FROM SelfAssessments
264+
WHERE ID = @selfAssessmentId"
265+
,
266+
new { selfAssessmentId }
267+
);
268+
return date;
269+
}
270+
208271
public (IEnumerable<SelfAssessmentDelegate>, int) GetSelfAssessmentDelegates(string searchString, int offSet, int itemsPerPage, string sortBy, string sortDirection,
209272
int? selfAssessmentId, int centreId, bool? isDelegateActive, bool? removed, bool? submitted, bool? signedOff)
210273
{

DigitalLearningSolutions.Data/DataServices/SupervisorDataService.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,8 @@ FROM CandidateAssessments AS CA
796796
WHERE (DelegateUserID = @delegateUserId) AND (RemovedDate IS NULL)
797797
AND (CompletedDate IS NULL)))
798798
AND ((rp.SupervisorSelfAssessmentReview = 1) OR (rp.SupervisorResultsReview = 1))
799-
AND (ISNULL(@categoryId, 0) = 0 OR rp.CategoryID = @categoryId)", new { delegateUserId, centreId, categoryId }
799+
AND (ISNULL(@categoryId, 0) = 0 OR rp.CategoryID = @categoryId) AND
800+
((CAST(rp.RetirementDate AS DATE) >= CAST(GETUTCDATE() AS DATE)) OR rp.RetirementDate IS NULL)", new { delegateUserId, centreId, categoryId }
800801
);
801802
}
802803

DigitalLearningSolutions.Data/Models/SelfAssessments/SelfAssessment.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
namespace DigitalLearningSolutions.Data.Models.SelfAssessments
1+
using System;
2+
3+
namespace DigitalLearningSolutions.Data.Models.SelfAssessments
24
{
35
public class SelfAssessment : CurrentLearningItem
46
{
@@ -11,6 +13,10 @@ public class SelfAssessment : CurrentLearningItem
1113
public string? ManageOptionalCompetenciesPrompt { get; set; }
1214
public string? QuestionLabel { get; set; }
1315
public string? DescriptionLabel { get; set; }
16+
public DateTime? RetirementDate { get; set; }
17+
18+
public DateTime? EnrolmentCutoffDate { get; set; }
19+
public string? RetirementReason { get; set; }
1420

1521
}
1622
}

0 commit comments

Comments
 (0)