Skip to content

Commit a88ecde

Browse files
authored
Merge pull request #2818 from TechnologyEnhancedLearning/Develop/Fixes/TD-4668-Issueshowingduplicateselfassessmentrecordson'SupervisorDashboard'screen
TD-4668 Issue showing duplicate self assessment records on 'Supervisor Dashboard' screen
2 parents 0597301 + 519c252 commit a88ecde

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

DigitalLearningSolutions.Data/DataServices/CourseDataService.cs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -533,17 +533,24 @@ LEFT OUTER JOIN UserCentreDetails AS UCD ON
533533
);
534534
}
535535
}
536-
537-
if (candidateAssessmentId > 1)
536+
if (candidateAssessmentId > 1 && supervisorDelegateId == 0)
537+
{
538+
connection.Execute(
539+
@"UPDATE CandidateAssessments SET RemovedDate = NULL, EnrolmentMethodId = @enrolmentMethodId, CompleteByDate = @completeByDateDynamic
540+
WHERE ID = @candidateAssessmentId",
541+
new { candidateAssessmentId, enrolmentMethodId, completeByDateDynamic }
542+
);
543+
}
544+
if (candidateAssessmentId > 1 && supervisorDelegateId !=0)
538545
{
539546
string sqlQuery = $@"
540547
BEGIN TRANSACTION
541548
UPDATE CandidateAssessments SET RemovedDate = NULL, EnrolmentMethodId = @enrolmentMethodId, CompleteByDate = @completeByDateDynamic
542549
WHERE ID = @candidateAssessmentId
543550
544551
UPDATE CandidateAssessmentSupervisors SET Removed = NULL
545-
{((selfAssessmentSupervisorRoleId > 0) ? " ,SelfAssessmentSupervisorRoleID = @selfAssessmentSupervisorRoleID" : string.Empty)}
546-
WHERE CandidateAssessmentID = @candidateAssessmentId
552+
{((selfAssessmentSupervisorRoleId > 0) ? " ,SelfAssessmentSupervisorRoleID = @selfAssessmentSupervisorRoleID" : string.Empty)}
553+
WHERE CandidateAssessmentID = @candidateAssessmentId
547554
548555
COMMIT TRANSACTION";
549556

0 commit comments

Comments
 (0)