TD-1944 Changed static value of callType to enum

Author: manishagarwalnhs

DigitalLearningSolutions.Data/Enums/ViewDelegateNavigationType.cs

@@ -0,0 +1,7 @@
+namespace DigitalLearningSolutions.Data.Enums
+{
+    public enum ViewDelegateNavigationType
+    {
+        PromoteToAdmin
+    }
+}

DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/PromoteToAdminController.cs

@@ -173,7 +173,7 @@ public IActionResult Index(AdminRolesFormData formData, int delegateId)
                 return new StatusCodeResult(500);
             }
             TempData["IsDelegatePromoted"] = true;
-            return RedirectToAction("Index", "ViewDelegate", new { delegateId = delegateId, callType = 1 });
+            return RedirectToAction("Index", "ViewDelegate", new { delegateId = delegateId, callType = ViewDelegateNavigationType.PromoteToAdmin });
         }
     }
 }

DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/ViewDelegateController.cs

@@ -57,7 +57,7 @@ IEmailVerificationDataService emailVerificationDataService
             this.emailVerificationDataService = emailVerificationDataService;
         }
 
-        public IActionResult Index(int delegateId, int? callType)
+        public IActionResult Index(int delegateId, string? callType)
         {
             var centreId = User.GetCentreIdKnownNotNull();
 
@@ -68,7 +68,7 @@ public IActionResult Index(int delegateId, int? callType)
                 return NotFound();
             }
 
-            if (callType == null && TempData["IsDelegatePromoted"] != null)
+            if (string.IsNullOrEmpty(callType) && TempData["IsDelegatePromoted"] != null)
             {
                 TempData.Remove("IsDelegatePromoted");
             }