Skip to content

Commit b7fc082

Browse files
committed
TD_5666 Made code changes after discussion and showed thee description on the Frameworks Interface.
1 parent 6661295 commit b7fc082

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

DigitalLearningSolutions.Data/DataServices/FrameworkDataService.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -863,15 +863,15 @@ public void RemoveCustomFlag(int flagId)
863863
public IEnumerable<FrameworkCompetencyGroup> GetFrameworkCompetencyGroups(int frameworkId)
864864
{
865865
var result = connection.Query<FrameworkCompetencyGroup, FrameworkCompetency, FrameworkCompetencyGroup>(
866-
@"SELECT fcg.ID, fcg.CompetencyGroupID, cg.Name, fcg.Ordering, fc.ID, c.ID AS CompetencyID, c.Name, c.Description, fc.Ordering, COUNT(caq.AssessmentQuestionID) AS AssessmentQuestions
866+
@"SELECT fcg.ID, fcg.CompetencyGroupID, cg.Name, cg.Description, fcg.Ordering, fc.ID, c.ID AS CompetencyID, c.Name, c.Description, fc.Ordering, COUNT(caq.AssessmentQuestionID) AS AssessmentQuestions
867867
,(SELECT COUNT(*) FROM CompetencyLearningResources clr WHERE clr.CompetencyID = c.ID AND clr.RemovedDate IS NULL) AS CompetencyLearningResourcesCount
868868
FROM FrameworkCompetencyGroups AS fcg INNER JOIN
869869
CompetencyGroups AS cg ON fcg.CompetencyGroupID = cg.ID LEFT OUTER JOIN
870870
FrameworkCompetencies AS fc ON fcg.ID = fc.FrameworkCompetencyGroupID LEFT OUTER JOIN
871871
Competencies AS c ON fc.CompetencyID = c.ID LEFT OUTER JOIN
872872
CompetencyAssessmentQuestions AS caq ON c.ID = caq.CompetencyID
873873
WHERE (fcg.FrameworkID = @frameworkId)
874-
GROUP BY fcg.ID, fcg.CompetencyGroupID, cg.Name, fcg.Ordering, fc.ID, c.ID, c.Name, c.Description, fc.Ordering
874+
GROUP BY fcg.ID, fcg.CompetencyGroupID, cg.Name, cg.Description, fcg.Ordering, fc.ID, c.ID, c.Name, c.Description, fc.Ordering
875875
ORDER BY fcg.Ordering, fc.Ordering",
876876
(frameworkCompetencyGroup, frameworkCompetency) =>
877877
{
@@ -1056,7 +1056,7 @@ int adminId
10561056
{
10571057
var numberOfAffectedRows = connection.Execute(
10581058
@"UPDATE CompetencyGroups SET Name = @name, UpdatedByAdminID = @adminId, Description = @description
1059-
WHERE ID = @competencyGroupId AND (Name <> @name OR Description <> @description)",
1059+
WHERE ID = @competencyGroupId AND (Name <> @name OR ISNULL(Description, '') <> ISNULL(@description, ''))",
10601060
new { name, adminId, competencyGroupId, description }
10611061
);
10621062
if (numberOfAffectedRows < 1)

DigitalLearningSolutions.Web/Views/Frameworks/Shared/_CompetencyGroupCard.cshtml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,12 @@
33
<details id="[email protected]" class="nhsuk-details nhsuk-expander nhsuk-u-margin-bottom-3" @((int)ViewData["GroupCount"] == 1 ? "open" : (ViewContext.RouteData.Values.ContainsKey("frameworkCompetencyGroupId") ? (ViewContext.RouteData.Values["frameworkCompetencyGroupId"].Equals(Model.FrameworkCompetencyGroup.ID.ToString()) ? "open" : "") : ""))>
44
<summary class="nhsuk-details__summary">
55
<span class="nhsuk-details__summary-text">
6-
7-
@Model.FrameworkCompetencyGroup.Name (@Model.FrameworkCompetencyGroup.FrameworkCompetencies.Count() @ViewData["VocabPlural"].ToString().ToLower())
6+
@Model.FrameworkCompetencyGroup.Name (@Model.FrameworkCompetencyGroup.FrameworkCompetencies.Count() @ViewData["VocabPlural"].ToString().ToLower())
7+
</span>
8+
<br />
9+
<br />
10+
<span class="nhsuk-u-secondary-text-color nhsuk-body">
11+
@Html.Raw(@Model.FrameworkCompetencyGroup.Description)
812
</span>
913
@if (Model.CanModify)
1014
{

0 commit comments

Comments
 (0)