Skip to content

Commit bdd85f1

Browse files
authored
Merge pull request #2952 from TechnologyEnhancedLearning/Develop/Fixes/TD-4950-FixSubmitResultFoDupeCompetency
TD-4950 Fix issue with verify m,ultiple competencies button being unavailable
2 parents bfa9282 + 9496e79 commit bdd85f1

File tree

1 file changed

+7
-5
lines changed
  • DigitalLearningSolutions.Web/Controllers/SupervisorController

1 file changed

+7
-5
lines changed

DigitalLearningSolutions.Web/Controllers/SupervisorController/Supervisor.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
using DigitalLearningSolutions.Web.Extensions;
1313
using DigitalLearningSolutions.Web.Helpers;
1414
using DigitalLearningSolutions.Web.ServiceFilter;
15-
using DigitalLearningSolutions.Web.Services;
1615
using DigitalLearningSolutions.Web.ViewModels.Common.SearchablePage;
1716
using DigitalLearningSolutions.Web.ViewModels.Supervisor;
1817
using GDS.MultiPageFormData.Enums;
@@ -368,6 +367,8 @@ public IActionResult ReviewDelegateSelfAssessment(int supervisorDelegateId, int
368367
var competencyIds = reviewedCompetencies.Select(c => c.Id).ToArray();
369368
var competencyFlags = frameworkService.GetSelectedCompetencyFlagsByCompetecyIds(competencyIds);
370369
var competencies = SupervisorCompetencyFilterHelper.FilterCompetencies(reviewedCompetencies, competencyFlags, searchModel);
370+
delegateSelfAssessment.ResultsVerificationRequests = competencies.SelectMany(competency => competency.AssessmentQuestions)
371+
.Count(question => question.Verified == null && question.UserIsVerifier == true);
371372
var searchViewModel = searchModel == null ?
372373
new SearchSupervisorCompetencyViewModel(supervisorDelegateId, searchModel?.SearchText, delegateSelfAssessment.ID, delegateSelfAssessment.IsSupervisorResultsReviewed, false, null, null)
373374
: searchModel.Initialise(searchModel.AppliedFilters, competencyFlags.ToList(), delegateSelfAssessment.IsSupervisorResultsReviewed, false);
@@ -395,6 +396,7 @@ public IActionResult ReviewDelegateSelfAssessment(int supervisorDelegateId, int
395396
(int)superviseDelegate.DelegateUserID
396397
);
397398
}
399+
398400
var competencySummaries = CertificateHelper.CanViewCertificate(reviewedCompetencies, model.SupervisorSignOffs);
399401
model.CompetencySummaries = competencySummaries;
400402
ViewBag.SupervisorSelfAssessmentReview = delegateSelfAssessment.SupervisorSelfAssessmentReview;
@@ -1389,7 +1391,7 @@ public IActionResult CompetencySelfAssessmentCertificatesupervisor(int candidate
13891391
}
13901392
var supervisorDelegateDetails = supervisorService.GetSupervisorDelegateDetailsForAdminId(adminId.Value);
13911393
var checkSupervisorDelegate = supervisorDelegateDetails.Where(x => x.DelegateUserID == competencymaindata.LearnerId).FirstOrDefault();
1392-
if ( (checkSupervisorDelegate == null) )
1394+
if ((checkSupervisorDelegate == null))
13931395
{
13941396
return RedirectToAction("StatusCode", "LearningSolutions", new { code = 403 });
13951397
}
@@ -1423,9 +1425,9 @@ public async Task<IActionResult> DownloadCertificate(int candidateAssessmentId)
14231425
{
14241426
return RedirectToAction("StatusCode", "LearningSolutions", new { code = 403 });
14251427
}
1426-
var supervisorDelegateDetails = supervisorService.GetSupervisorDelegateDetailsForAdminId(adminId.Value);
1427-
var checkSupervisorDelegate = supervisorDelegateDetails.Where(x => x.DelegateUserID == competencymaindata.LearnerId).FirstOrDefault();
1428-
if (checkSupervisorDelegate == null) return RedirectToAction("StatusCode", "LearningSolutions", new { code = 403 });
1428+
var supervisorDelegateDetails = supervisorService.GetSupervisorDelegateDetailsForAdminId(adminId.Value);
1429+
var checkSupervisorDelegate = supervisorDelegateDetails.Where(x => x.DelegateUserID == competencymaindata.LearnerId).FirstOrDefault();
1430+
if (checkSupervisorDelegate == null) return RedirectToAction("StatusCode", "LearningSolutions", new { code = 403 });
14291431
var delegateUserId = competencymaindata.LearnerId;
14301432
var competencycount = selfAssessmentService.GetCompetencyCountSelfAssessmentCertificate(candidateAssessmentId);
14311433
var accessors = selfAssessmentService.GetAccessor(competencymaindata.SelfAssessmentID, competencymaindata.LearnerId);

0 commit comments

Comments
 (0)