Skip to content

Commit c4483b4

Browse files
authored
Merge pull request #2821 from TechnologyEnhancedLearning/Develop/Fix/TD-4671-Delegate-activities-Course-DateTime-Issue
TD-4671-Course enrolled, lastupdated and completed date converted to local date time
2 parents 50d2325 + 4156972 commit c4483b4

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

DigitalLearningSolutions.Web/Controllers/LoginController.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ public async Task<IActionResult> ChooseCentre(int centreId, string? returnUrl)
179179
{
180180
var userEntity = userService.GetUserById(User.GetUserIdKnownNotNull());
181181
var centreAccountSet = userEntity?.GetCentreAccountSet(centreId);
182+
DateHelper.userTimeZone ??= User.GetUserTimeZone(CustomClaimTypes.UserTimeZone);
182183

183184
if (centreAccountSet?.IsCentreActive != true)
184185
{

DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/ActivityDelegatesController.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
using System;
2323
using System.Collections.Generic;
2424
using System.Linq;
25+
using DateHelper = DigitalLearningSolutions.Web.Helpers.DateHelper;
2526

2627
[FeatureGate(FeatureFlags.RefactoredTrackingSystem)]
2728
[Authorize(Policy = CustomPolicies.UserCentreAdmin)]
@@ -221,11 +222,17 @@ public IActionResult Index(
221222
(courseDelegatesData, resultCount) = courseDelegatesService.GetCoursesAndCourseDelegatesPerPageForCentre(searchString ?? string.Empty, offSet, itemsPerPage ?? 0, sortBy, sortDirection,
222223
customisationId, centreId, adminCategoryId, isDelegateActive, isProgressLocked, removed, hasCompleted, answer1, answer2, answer3);
223224
}
225+
foreach (var courseDelegate in courseDelegatesData.Delegates)
226+
{
227+
courseDelegate.Enrolled = (DateTime)DateHelper.GetLocalDateTime(courseDelegate.Enrolled);
228+
courseDelegate.LastUpdated = DateHelper.GetLocalDateTime(courseDelegate.LastUpdated);
229+
courseDelegate.Completed = courseDelegate.Completed?.TimeOfDay == TimeSpan.Zero ? courseDelegate.Completed : DateHelper.GetLocalDateTime(courseDelegate.Completed);
230+
}
224231
}
225232
else
226233
{
227234
(selfAssessmentDelegatesData, resultCount) = selfAssessmentService.GetSelfAssessmentDelegatesPerPage(searchString ?? string.Empty, offSet, itemsPerPage ?? 0, sortBy, sortDirection,
228-
selfAssessmentId, centreId, isDelegateActive, removed, submitted, signedOff);
235+
selfAssessmentId, centreId, isDelegateActive, removed, submitted, signedOff);
229236

230237
if (selfAssessmentDelegatesData?.Delegates?.Count() == 0 && resultCount > 0)
231238
{

DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/Shared/_DelegateCourseProgressDetails.cshtml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
@using DigitalLearningSolutions.Data.Helpers
2+
@using DateHelper = DigitalLearningSolutions.Web.Helpers.DateHelper
23
@using DigitalLearningSolutions.Web.Models.Enums
34
@using DigitalLearningSolutions.Web.ViewModels.TrackingSystem.Delegates.Shared
45
@model DelegateCourseInfoViewModel
6+
@{
7+
var courseCompleted = Model.Completed != null ?
8+
Convert.ToDateTime(Model.Completed).TimeOfDay == TimeSpan.Zero ? Convert.ToDateTime(Model.Completed).ToString(DateHelper.StandardDateFormat) :
9+
Convert.ToDateTime(Model.Completed).ToString(DateHelper.StandardDateAndTimeFormat)
10+
: "-";
11+
}
512

613
<dl class="nhsuk-summary-list details-list-with-button word-break">
714
@if (Model.AccessedVia.Equals(DelegateAccessRoute.ActivityDelegates))
@@ -55,7 +62,7 @@
5562
Complete by
5663
</dt>
5764
<dd class="nhsuk-summary-list__value" data-name-for-sorting="complete-by-date">
58-
@(Model.CompleteBy ?? "-")
65+
@(Model.CompleteBy != null ? Convert.ToDateTime(Model.CompleteBy).ToString(DateHelper.StandardDateFormat) : "-")
5966
</dd>
6067
<dd class="nhsuk-summary-list__actions">
6168
<a data-return-page-enabled="true"
@@ -84,7 +91,7 @@
8491
Completed
8592
</dt>
8693
<dd class="nhsuk-summary-list__value" data-name-for-sorting="completed-date">
87-
@(Model.Completed ?? "-")
94+
@(courseCompleted)
8895
</dd>
8996
<dd class="nhsuk-summary-list__actions">
9097
<a data-return-page-enabled="true"

0 commit comments

Comments
 (0)