Skip to content

Commit d0f7bfa

Browse files
authored
Merge pull request #2897 from TechnologyEnhancedLearning/Develop/Features/TD-4879-LimittheselfassessmentsreturnedinDelegateActivitiesbyadmincoursecategory
TD-4879 Limit the self assessments returned in Delegate Activities by admin course category
2 parents de21044 + 3b96ea3 commit d0f7bfa

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

DigitalLearningSolutions.Data/DataServices/SelfAssessmentDataService/SelfAssessmentDataService.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,21 +229,21 @@ FROM SelfAssessments
229229
sa.SupervisorSelfAssessmentReview,
230230
sa.SupervisorResultsReview";
231231

232-
var fromTableQuery = $@" FROM dbo.SelfAssessments AS sa
232+
var fromTableQuery = $@" FROM dbo.SelfAssessments AS sa
233233
INNER JOIN dbo.CandidateAssessments AS ca WITH (NOLOCK) ON sa.ID = ca.SelfAssessmentID
234234
INNER JOIN dbo.CentreSelfAssessments AS csa WITH (NOLOCK) ON sa.ID = csa.SelfAssessmentID
235235
INNER JOIN dbo.DelegateAccounts da WITH (NOLOCK) ON ca.CentreID = da.CentreID AND ca.DelegateUserID = da.UserID AND da.CentreID = csa.CentreID
236236
INNER JOIN dbo.Users u WITH (NOLOCK) ON DA.UserID = u.ID
237237
LEFT JOIN UserCentreDetails AS ucd WITH (NOLOCK) ON ucd.UserID = da.UserID AND ucd.centreID = da.CentreID
238-
LEFT OUTER JOIN AdminAccounts AS aaEnrolledBy WITH (NOLOCK) ON aaEnrolledBy.ID = ca.EnrolledByAdminID
238+
LEFT OUTER JOIN AdminAccounts AS aaEnrolledBy WITH (NOLOCK) ON aaEnrolledBy.ID = ca.EnrolledByAdminID
239239
LEFT OUTER JOIN Users AS uEnrolledBy WITH (NOLOCK) ON uEnrolledBy.ID = aaEnrolledBy.UserID
240240
LEFT JOIN dbo.CandidateAssessmentSupervisors AS cas WITH (NOLOCK) ON ca.ID = cas.CandidateAssessmentID
241241
LEFT JOIN dbo.CandidateAssessmentSupervisorVerifications AS casv WITH (NOLOCK) ON cas.ID = casv.CandidateAssessmentSupervisorID AND
242242
(casv.Verified IS NOT NULL AND casv.SignedOff = 1)
243243
244244
WHERE sa.ID = @selfAssessmentId
245245
AND da.CentreID = @centreID AND csa.CentreID = @centreID
246-
AND (ca.RemovedDate IS NULL)
246+
AND (ca.RemovedDate IS NULL) AND ( aaEnrolledBy.CategoryID IS NULL OR sa.CategoryID = aaEnrolledBy.CategoryID)
247247
AND ( u.FirstName + ' ' + u.LastName + ' ' + COALESCE(ucd.Email, u.PrimaryEmail) + ' ' + COALESCE(da.CandidateNumber, '') LIKE N'%' + @searchString + N'%')
248248
AND ((@isDelegateActive IS NULL) OR (@isDelegateActive = 1 AND (da.Active = 1)) OR (@isDelegateActive = 0 AND (da.Active = 0)))
249249
AND ((@removed IS NULL) OR (@removed = 1 AND (ca.RemovedDate IS NOT NULL)) OR (@removed = 0 AND (ca.RemovedDate IS NULL)))

0 commit comments

Comments
 (0)