Skip to content

Commit d55f09d

Browse files
committed
Begins to implement remove competency from assessment functionality
1 parent b5d1f4c commit d55f09d

File tree

4 files changed

+18
-7
lines changed

4 files changed

+18
-7
lines changed

DigitalLearningSolutions.Web/Controllers/CompetencyAssessmentsController/CompetencyAssessments.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -579,15 +579,20 @@ public IActionResult AddComptencies(AddCompetenciesFormData model, int competenc
579579
{
580580
if (!ModelState.IsValid)
581581
{
582-
583582
//reload model and view
584583
}
585-
if (model.SelectedCompetencyIds.Count() > 0)
584+
if (model.SelectedCompetencyIds != null)
586585
{
587586
competencyAssessmentService.InsertCompetenciesIntoAssessmentFromFramework(model.SelectedCompetencyIds, frameworkId, competencyAssessmentId);
588587
}
589588
competencyAssessmentService.UpdateSelectCompetenciesTaskStatus(competencyAssessmentId, false, null);
590589
return RedirectToAction("ViewSelectedCompetencies", new { competencyAssessmentId });
591590
}
591+
[Route("/CompetencyAssessments/{competencyAssessmentId}/Competencies/Delete/{competencyId}")]
592+
public IActionResult DeleteCompetency(int competencyAssessmentId, int competencyId)
593+
{
594+
competencyAssessmentService.RemoveCompetencyFromAssessment(competencyAssessmentId, competencyId);
595+
return RedirectToAction("ViewSelectedCompetencies", new { competencyAssessmentId });
596+
}
592597
}
593598
}

DigitalLearningSolutions.Web/Services/CompetencyAssessmentService.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ public interface ICompetencyAssessmentService
5454

5555
//DELETE DATA
5656
bool RemoveFrameworkCompetenciesFromAssessment(int competencyAssessmentId, int frameworkId);
57+
bool RemoveCompetencyFromAssessment(int competencyAssessmentId, int competencyId);
5758
}
5859
public class CompetencyAssessmentService : ICompetencyAssessmentService
5960
{
@@ -240,5 +241,10 @@ public bool InsertCompetenciesIntoAssessmentFromFramework(int[] selectedCompeten
240241
{
241242
return competencyAssessmentDataService.InsertCompetenciesIntoAssessmentFromFramework(selectedCompetencyIds, frameworkId, competencyAssessmentId);
242243
}
244+
245+
public bool RemoveCompetencyFromAssessment(int competencyAssessmentId, int competencyId)
246+
{
247+
return competencyAssessmentDataService.RemoveCompetencyFromAssessment(competencyAssessmentId, competencyId);
248+
}
243249
}
244250
}

DigitalLearningSolutions.Web/Views/CompetencyAssessments/ViewSelectedCompetencies.cshtml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
{
6868
foreach (var competency in group)
6969
{
70-
<div id="fc[email protected]" class="nhsuk-card nhsuk-u-margin-bottom-5 nhsuk-u-margin-left-3">
70+
<div id="competency[email protected]" class="nhsuk-card nhsuk-u-margin-bottom-5 nhsuk-u-margin-left-3">
7171
<div class="nhsuk-card__content">
7272
@* <partial name="_CompetencyFlags" model="Model.CompetencyFlags" /> *@
7373
@if (competency.CompetencyDescription != null)
@@ -90,9 +90,9 @@
9090
<div class="nhsuk-grid-column-three-quarters">
9191
@if (Model.UserRole > 1)
9292
{
93-
<a class="nhsuk-button nhsuk-button--secondary small-edit-button nhsuk-u-margin-right-1" role="button" asp-action="MoveCompetency" asp-route-competencyGroupId="@group.Key.GroupId" asp-route-step="true" asp-route-direction="UP" asp-route-selfAssessmentId="@(ViewContext.RouteData.Values["ID"])" asp-route-competencyId="@competency.CompetencyID">Move <span class="visually-hidden">@competency.CompetencyName</span>up </a>
94-
<a class="nhsuk-button nhsuk-button--secondary small-edit-button nhsuk-u-margin-right-1" role="button" asp-action="MoveCompetency" asp-route-competencyGroupId="@group.Key.GroupId" asp-route-step="true" asp-route-direction="DOWN" asp-route-selfAssessmentId="@(ViewContext.RouteData.Values["ID"])" asp-route-competencyId="@competency.CompetencyID">Move <span class="visually-hidden">@competency.CompetencyName</span>down </a>
95-
<a class="nhsuk-button nhsuk-button--secondary delete-button small-edit-button nhsuk-u-margin-right-1" role="button" asp-action="DeleteCompetency" asp-route-competencyGroupId="@group.Key.GroupId" asp-route-selfAssessmentId="@(ViewContext.RouteData.Values["ID"])" asp-route-competencyId="@competency.CompetencyID">Remove <span class="visually-hidden">@competency.CompetencyName</span></a>
93+
<a class="nhsuk-button nhsuk-button--secondary small-edit-button nhsuk-u-margin-right-1" role="button" asp-action="MoveCompetency" asp-route-competencyGroupId="@group.Key.GroupId" asp-route-step="true" asp-route-direction="UP" asp-route-competencyAssessmentId="@(ViewContext.RouteData.Values["competencyAssessmentId"])" asp-route-competencyId="@competency.CompetencyID">Move <span class="visually-hidden">@competency.CompetencyName</span>up </a>
94+
<a class="nhsuk-button nhsuk-button--secondary small-edit-button nhsuk-u-margin-right-1" role="button" asp-action="MoveCompetency" asp-route-competencyGroupId="@group.Key.GroupId" asp-route-step="true" asp-route-direction="DOWN" asp-route-competencyAssessmentId="@(ViewContext.RouteData.Values["competencyAssessmentId"])" asp-route-competencyId="@competency.CompetencyID">Move <span class="visually-hidden">@competency.CompetencyName</span>down </a>
95+
<a class="nhsuk-button nhsuk-button--secondary delete-button small-edit-button nhsuk-u-margin-right-1" role="button" asp-action="DeleteCompetency" asp-route-competencyAssessmentId="@(ViewContext.RouteData.Values["competencyAssessmentId"])" asp-route-competencyId="@competency.CompetencyID">Remove <span class="visually-hidden">@competency.CompetencyName</span></a>
9696
}
9797
</div>
9898
</div>

DigitalLearningSolutions.Web/Views/Frameworks/Index.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ else
7878
<div class="nhsuk-card">
7979
<div class="nhsuk-card__content">
8080
<p class="nhsuk-heading-xl nhsuk-u-font-size-32 nhsuk-u-margin-bottom-3">
81-
@Model.DashboardData.CompetencyAssessmentCount Competency Assessments
81+
@Model.DashboardData.CompetencyAssessmentCount Assessments
8282
</p>
8383
<ul class="nhsuk-contents-list__list">
8484
@if (Model.IsWorkforceManager | Model.IsWorkforceContributor)

0 commit comments

Comments
 (0)