TD-3885 Making use of environment variables.

Author: rshrirohit

DigitalLearningSolutions.Web.Tests/Controllers/TrackingSystem/Delegates/AllDelegatesControllerTests.cs

@@ -17,6 +17,7 @@
     using Microsoft.AspNetCore.Http;
     using NUnit.Framework;
     using Microsoft.Extensions.Configuration;
+    using Microsoft.AspNetCore.Hosting;
 
     public class AllDelegatesControllerTests
     {
@@ -32,6 +33,7 @@ public class AllDelegatesControllerTests
         private IUserDataService userDataService = null!;
         private IGroupsService groupsService = null!;
         private IConfiguration? configuration;
+        private IWebHostEnvironment? env;
 
         [SetUp]
         public void Setup()
@@ -46,6 +48,7 @@ public void Setup()
             configuration = A.Fake<IConfiguration>();
             httpRequest = A.Fake<HttpRequest>();
             httpResponse = A.Fake<HttpResponse>();
+            env = A.Fake<IWebHostEnvironment>();
 
             const string cookieValue = "ActiveStatus|Active|false";
 
@@ -56,7 +59,8 @@ public void Setup()
                     jobGroupsDataService,
                     paginateService,
                     groupsService,
-                    configuration
+                    configuration,
+                    env
                 )
                 .WithMockHttpContext(httpRequest, CookieName, cookieValue, httpResponse)
                 .WithMockUser(true)

DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/AllDelegatesController.cs

@@ -18,7 +18,7 @@
     using Microsoft.FeatureManagement.Mvc;
     using Microsoft.Extensions.Configuration;
     using DigitalLearningSolutions.Data.Extensions;
-    using Microsoft.AspNetCore.Http.Extensions;
+    using Microsoft.AspNetCore.Hosting;
 
     [FeatureGate(FeatureFlags.RefactoredTrackingSystem)]
     [Authorize(Policy = CustomPolicies.UserCentreAdmin)]
@@ -35,6 +35,7 @@ public class AllDelegatesController : Controller
         private readonly IUserDataService userDataService;
         private readonly IGroupsService groupsService;
         private readonly IConfiguration configuration;
+        private readonly IWebHostEnvironment env;
 
         public AllDelegatesController(
             IDelegateDownloadFileService delegateDownloadFileService,
@@ -43,7 +44,8 @@ public AllDelegatesController(
             IJobGroupsDataService jobGroupsDataService,
             IPaginateService paginateService,
             IGroupsService groupsService,
-            IConfiguration configuration
+            IConfiguration configuration,
+            IWebHostEnvironment env
         )
         {
             this.delegateDownloadFileService = delegateDownloadFileService;
@@ -53,6 +55,7 @@ IConfiguration configuration
             this.paginateService = paginateService;
             this.groupsService = groupsService;
             this.configuration = configuration;
+            this.env = env;
         }
 
         [NoCaching]
@@ -77,7 +80,8 @@ public IActionResult Index(
 
             sortBy ??= DefaultSortByOptions.Name.PropertyName;
             sortDirection ??= GenericSortingHelper.Ascending;
-            if (HttpContext.Request.GetDisplayUrl().ToString().ToLower().Contains("uat"))
+
+            if (string.Equals(env.EnvironmentName, "UAT", StringComparison.OrdinalIgnoreCase))
             {
                 DelegateFilterCookieName = "DelegateFilterUat";
             }