TD-5548 Issue showing 'some existing competency records changed order' on 'competency file uploaded' screen when even modified the competency names

Author: sherif-olaboye

DigitalLearningSolutions.Data/DataServices/FrameworkDataService.cs

@@ -80,13 +80,13 @@ int adminId
 
         IEnumerable<GenericSelectList> GetAssessmentQuestions(int frameworkId, int adminId);
 
-        FrameworkDefaultQuestionUsage GetFrameworkDefaultQuestionUsage(int frameworkId, int assessmentQuestionId);
+        FrameworkDefaultQuestionUsage? GetFrameworkDefaultQuestionUsage(int frameworkId, int assessmentQuestionId);
 
         IEnumerable<GenericSelectList> GetAssessmentQuestionsForCompetency(int frameworkCompetencyId, int adminId);
 
-        AssessmentQuestionDetail GetAssessmentQuestionDetailById(int assessmentQuestionId, int adminId);
+        AssessmentQuestionDetail? GetAssessmentQuestionDetailById(int assessmentQuestionId, int adminId);
 
-        LevelDescriptor GetLevelDescriptorForAssessmentQuestionId(int assessmentQuestionId, int adminId, int level);
+        LevelDescriptor? GetLevelDescriptorForAssessmentQuestionId(int assessmentQuestionId, int adminId, int level);
 
         IEnumerable<CompetencyResourceAssessmentQuestionParameter>
             GetSignpostingResourceParametersByFrameworkAndCompetencyId(int frameworkId, int competencyId);
@@ -122,7 +122,7 @@ bool zeroBased
         FrameworkReviewOutcomeNotification? GetFrameworkReviewNotification(int reviewId);
 
         //INSERT DATA
-        BrandedFramework CreateFramework(DetailFramework detailFramework, int adminId);
+        BrandedFramework? CreateFramework(DetailFramework detailFramework, int adminId);
 
         int InsertCompetencyGroup(string groupName, string? groupDescription, int adminId, int? frameworkId);
 
@@ -366,7 +366,7 @@ public FrameworkDataService(IDbConnection connection, ILogger<FrameworkDataServi
             );
         }
 
-        public BaseFramework GetBaseFrameworkByFrameworkId(int frameworkId, int adminId)
+        public BaseFramework? GetBaseFrameworkByFrameworkId(int frameworkId, int adminId)
         {
             return connection.QueryFirstOrDefault<BaseFramework>(
                 $@"SELECT {BaseFrameworkFields}
@@ -376,7 +376,7 @@ public BaseFramework GetBaseFrameworkByFrameworkId(int frameworkId, int adminId)
             );
         }
 
-        public BrandedFramework GetBrandedFrameworkByFrameworkId(int frameworkId, int adminId)
+        public BrandedFramework? GetBrandedFrameworkByFrameworkId(int frameworkId, int adminId)
         {
             return connection.QueryFirstOrDefault<BrandedFramework>(
                 $@"SELECT {BaseFrameworkFields} {BrandedFrameworkFields}
@@ -483,7 +483,7 @@ public IEnumerable<FrameworkCompetency> GetAllCompetenciesForAdminId(string name
             );
         }
 
-        public BrandedFramework CreateFramework(DetailFramework detailFramework, int adminId)
+        public BrandedFramework? CreateFramework(DetailFramework detailFramework, int adminId)
         {
             string frameworkName = detailFramework.FrameworkName;
             var description = detailFramework.Description;
@@ -531,7 +531,7 @@ public BrandedFramework CreateFramework(DetailFramework detailFramework, int adm
                 return new BrandedFramework();
             }
 
-            return connection.QueryFirstOrDefault<BrandedFramework>(
+            return connection.QueryFirstOrDefault<BrandedFramework?>(
                 $@"SELECT {BaseFrameworkFields}
                       FROM {FrameworkTables}
                       WHERE FrameworkName = @frameworkName AND OwnerAdminID = @adminId",
@@ -866,7 +866,7 @@ public IEnumerable<FrameworkCompetencyGroup> GetFrameworkCompetencyGroups(int fr
                 @"SELECT fcg.ID, fcg.CompetencyGroupID, cg.Name, fcg.Ordering, fc.ID, c.ID AS CompetencyID, c.Name, c.Description, fc.Ordering, COUNT(caq.AssessmentQuestionID) AS AssessmentQuestions
                     ,(SELECT COUNT(*) FROM CompetencyLearningResources clr WHERE clr.CompetencyID = c.ID AND clr.RemovedDate IS NULL) AS CompetencyLearningResourcesCount
                     FROM   FrameworkCompetencyGroups AS fcg INNER JOIN
-                      CompetencyGroups AS cg ON fcg.CompetencyGroupID = cg.ID LEFT OUTER JOIN
+                      CompetencyGroups AS cg ON fcg.CompetencyGroupID = cg.ID INNER JOIN
                        FrameworkCompetencies AS fc ON fcg.ID = fc.FrameworkCompetencyGroupID LEFT OUTER JOIN
                        Competencies AS c ON fc.CompetencyID = c.ID LEFT OUTER JOIN
                       CompetencyAssessmentQuestions AS caq ON c.ID = caq.CompetencyID
@@ -1518,7 +1518,7 @@ FROM AssessmentQuestionInputTypes"
             );
         }
 
-        public FrameworkDefaultQuestionUsage GetFrameworkDefaultQuestionUsage(int frameworkId, int assessmentQuestionId)
+        public FrameworkDefaultQuestionUsage? GetFrameworkDefaultQuestionUsage(int frameworkId, int assessmentQuestionId)
         {
             return connection.QueryFirstOrDefault<FrameworkDefaultQuestionUsage>(
                 @"SELECT @assessmentQuestionId AS ID,
@@ -1619,7 +1619,7 @@ FROM   CompetencyAssessmentQuestions INNER JOIN
             }
         }
 
-        public AssessmentQuestionDetail GetAssessmentQuestionDetailById(int assessmentQuestionId, int adminId)
+        public AssessmentQuestionDetail? GetAssessmentQuestionDetailById(int assessmentQuestionId, int adminId)
         {
             return connection.QueryFirstOrDefault<AssessmentQuestionDetail>(
                 $@"{AssessmentQuestionFields}{AssessmentQuestionDetailFields}
@@ -1629,7 +1629,7 @@ public AssessmentQuestionDetail GetAssessmentQuestionDetailById(int assessmentQu
             );
         }
 
-        public LevelDescriptor GetLevelDescriptorForAssessmentQuestionId(
+        public LevelDescriptor? GetLevelDescriptorForAssessmentQuestionId(
             int assessmentQuestionId,
             int adminId,
             int level
@@ -2500,7 +2500,7 @@ FROM Flags AS f
                         FOR XML PATH(''), TYPE).value('.', 'NVARCHAR(MAX)'), 1, 2, '') AS FlagsCsv
                     FROM 
                          Competencies AS c INNER JOIN
-                         FrameworkCompetencies AS fc ON c.ID = fc.CompetencyID LEFT JOIN
+                         FrameworkCompetencies AS fc ON c.ID = fc.CompetencyID INNER JOIN
                          FrameworkCompetencyGroups AS fcg ON fc.FrameworkCompetencyGroupID = fcg.ID LEFT JOIN
                          CompetencyGroups AS cg ON fcg.CompetencyGroupID = cg.ID
                     WHERE (fc.FrameworkID = @frameworkId)