Merge pull request #2733 from TechnologyEnhancedLearning/Develop/Fixes/TD-4207-Clickingbrowserbackbuttonafterdeletingthe'DelegateGroup'showingconsole'404'errorinsteadof'410'error

rshrirohit · web-flow · commit ddba9908a301 · 2024-07-01T15:25:20.000+01:00
TD-4207 Clicking browser back button after deleting the 'Delegate Group' showing console '404' error instead of '410' error
diff --git a/DigitalLearningSolutions.Web/ServiceFilter/VerifyAdminUserCanAccessGroup.cs b/DigitalLearningSolutions.Web/ServiceFilter/VerifyAdminUserCanAccessGroup.cs
@@ -26,7 +26,11 @@ public void OnActionExecuting(ActionExecutingContext context)
             var groupId = int.Parse(context.RouteData.Values["groupId"].ToString()!);
             var groupCentreId = groupsService.GetGroupCentreId(groupId);
 
-            if (controller.User.GetCentreIdKnownNotNull() != groupCentreId)
+            if (groupCentreId == 0)
+            {
+                context.Result = new RedirectToActionResult("StatusCode", "LearningSolutions", new { code = 410 });
+            }
+            else if (controller.User.GetCentreIdKnownNotNull() != groupCentreId)
             {
                 context.Result = new NotFoundResult();
             }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,11 @@ public void OnActionExecuting(ActionExecutingContext context)`
`26`	`26`	`var groupId = int.Parse(context.RouteData.Values["groupId"].ToString()!);`
`27`	`27`	`var groupCentreId = groupsService.GetGroupCentreId(groupId);`
`28`	`28`
`29`		`- if (controller.User.GetCentreIdKnownNotNull() != groupCentreId)`
	`29`	`+ if (groupCentreId == 0)`
	`30`	`+ {`
	`31`	`+ context.Result = new RedirectToActionResult("StatusCode", "LearningSolutions", new { code = 410 });`
	`32`	`+ }`
	`33`	`+ else if (controller.User.GetCentreIdKnownNotNull() != groupCentreId)`
`30`	`34`	`{`
`31`	`35`	`context.Result = new NotFoundResult();`
`32`	`36`	`}`