Skip to content

Commit de59eae

Browse files
authored
Merge pull request #3330 from TechnologyEnhancedLearning/Develop/feature/TD-5535-Archived-SA-In-LearningPortal
TD-5535-Modified SQL query/stored procedure to hide retired self-assessments
2 parents b9e2b5b + 4b05347 commit de59eae

File tree

8 files changed

+127
-52
lines changed

8 files changed

+127
-52
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
using FluentMigrator;
2+
3+
namespace DigitalLearningSolutions.Data.Migrations
4+
{
5+
[Migration(202507240953)]
6+
public class Alter_GetActivitiesForDelegateEnrolment_Retired_SA : Migration
7+
{
8+
public override void Up()
9+
{
10+
Execute.Sql(Properties.Resources.TD_5535_Alter_GetActivitiesForDelegateEnrolment_Up);
11+
}
12+
public override void Down()
13+
{
14+
Execute.Sql(Properties.Resources.TD_5535_Alter_GetActivitiesForDelegateEnrolment_Down);
15+
}
16+
}
17+
}
18+

DigitalLearningSolutions.Data.Migrations/Properties/Resources.Designer.cs

Lines changed: 64 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

DigitalLearningSolutions.Data.Migrations/Properties/Resources.resx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -499,4 +499,10 @@
499499
<data name="TD-5759_CreateOrAlterSelfAssessmentReportSPandTVF-Fix_UP" type="System.Resources.ResXFileRef, System.Windows.Forms">
500500
<value>..\Scripts\TD-5759_CreateOrAlterSelfAssessmentReportSPandTVF-Fix_UP.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-8</value>
501501
</data>
502+
<data name="TD_5535_Alter_GetActivitiesForDelegateEnrolment_Down" type="System.Resources.ResXFileRef, System.Windows.Forms">
503+
<value>..\Scripts\TD-5535-Alter_GetActivitiesForDelegateEnrolment_Down.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
504+
</data>
505+
<data name="TD_5535_Alter_GetActivitiesForDelegateEnrolment_Up" type="System.Resources.ResXFileRef, System.Windows.Forms">
506+
<value>..\Scripts\TD-5535-Alter_GetActivitiesForDelegateEnrolment_Up.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
507+
</data>
502508
</root>

DigitalLearningSolutions.Data/DataServices/SelfAssessmentDataService/CandidateAssessmentsDataService.cs

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -12,28 +12,31 @@ public IEnumerable<CurrentSelfAssessment> GetSelfAssessmentsForCandidate(int del
1212
{
1313
return connection.Query<CurrentSelfAssessment>(
1414
@"SELECT SelfAssessment.Id,
15-
SelfAssessment.Name,
16-
SelfAssessment.Description,
17-
SelfAssessment.IncludesSignposting,
18-
SelfAssessment.IncludeRequirementsFilters,
19-
SelfAssessment. IsSupervisorResultsReviewed,
20-
SelfAssessment.ReviewerCommentsLabel,
21-
SelfAssessment. Vocabulary,
22-
SelfAssessment. NumberOfCompetencies,
23-
SelfAssessment.StartedDate,
24-
SelfAssessment.LastAccessed,
25-
SelfAssessment.CompleteByDate,
26-
SelfAssessment.CandidateAssessmentId,
27-
SelfAssessment.UserBookmark,
28-
SelfAssessment.UnprocessedUpdates,
29-
SelfAssessment.LaunchCount,
30-
SelfAssessment. IsSelfAssessment,
31-
SelfAssessment.SubmittedDate,
32-
SelfAssessment. CentreName,
33-
SelfAssessment.EnrolmentMethodId,
34-
Signoff.SignedOff,
35-
Signoff.Verified,
36-
EnrolledByForename +' '+EnrolledBySurname AS EnrolledByFullName
15+
SelfAssessment.Name,
16+
SelfAssessment.Description,
17+
SelfAssessment.IncludesSignposting,
18+
SelfAssessment.IncludeRequirementsFilters,
19+
SelfAssessment. IsSupervisorResultsReviewed,
20+
SelfAssessment.ReviewerCommentsLabel,
21+
SelfAssessment. Vocabulary,
22+
SelfAssessment. NumberOfCompetencies,
23+
SelfAssessment.StartedDate,
24+
SelfAssessment.LastAccessed,
25+
SelfAssessment.CompleteByDate,
26+
SelfAssessment.CandidateAssessmentId,
27+
SelfAssessment.UserBookmark,
28+
SelfAssessment.UnprocessedUpdates,
29+
SelfAssessment.LaunchCount,
30+
SelfAssessment. IsSelfAssessment,
31+
SelfAssessment.SubmittedDate,
32+
SelfAssessment. CentreName,
33+
SelfAssessment.EnrolmentMethodId,
34+
SelfAssessment.RetirementDate,
35+
SelfAssessment.EnrolmentCutoffDate,
36+
SelfAssessment.RetirementReason,
37+
Signoff.SignedOff,
38+
Signoff.Verified,
39+
EnrolledByForename +' '+EnrolledBySurname AS EnrolledByFullName
3740
FROM (SELECT
3841
CA.SelfAssessmentID AS Id,
3942
SA.Name,
@@ -56,7 +59,10 @@ public IEnumerable<CurrentSelfAssessment> GetSelfAssessmentsForCandidate(int del
5659
CR.CentreName AS CentreName,
5760
CA.EnrolmentMethodId,
5861
uEnrolledBy.FirstName AS EnrolledByForename,
59-
uEnrolledBy.LastName AS EnrolledBySurname
62+
uEnrolledBy.LastName AS EnrolledBySurname,
63+
SA.RetirementDate,
64+
SA.EnrolmentCutoffDate,
65+
SA.RetirementReason
6066
FROM Centres AS CR INNER JOIN
6167
CandidateAssessments AS CA INNER JOIN
6268
SelfAssessments AS SA ON CA.SelfAssessmentID = SA.ID ON CR.CentreID = CA.CentreID INNER JOIN
@@ -71,7 +77,7 @@ Competencies AS C RIGHT OUTER JOIN
7177
AND (ISNULL(@adminIdCategoryID, 0) = 0 OR sa.CategoryID = @adminIdCategoryId)
7278
GROUP BY
7379
CA.SelfAssessmentID, SA.Name, SA.Description, SA.IncludesSignposting, SA.SupervisorResultsReview,
74-
SA.ReviewerCommentsLabel, SA.IncludeRequirementsFilters,
80+
SA.ReviewerCommentsLabel, SA.IncludeRequirementsFilters, SA.RetirementDate,SA.EnrolmentCutoffDate,SA.RetirementReason,
7581
COALESCE(SA.Vocabulary, 'Capability'), CA.StartedDate, CA.LastAccessed, CA.CompleteByDate,
7682
CA.ID,
7783
CA.UserBookmark, CA.UnprocessedUpdates, CA.LaunchCount, CA.SubmittedDate, CR.CentreName,CA.EnrolmentMethodId,

DigitalLearningSolutions.Data/Models/SelfAssessments/SelfAssessment.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
namespace DigitalLearningSolutions.Data.Models.SelfAssessments
1+
using System;
2+
3+
namespace DigitalLearningSolutions.Data.Models.SelfAssessments
24
{
35
public class SelfAssessment : CurrentLearningItem
46
{
@@ -11,6 +13,9 @@ public class SelfAssessment : CurrentLearningItem
1113
public string? ManageOptionalCompetenciesPrompt { get; set; }
1214
public string? QuestionLabel { get; set; }
1315
public string? DescriptionLabel { get; set; }
16+
public DateTime? RetirementDate { get; set; }
17+
public DateTime? EnrolmentCutoffDate { get; set; }
18+
public string? RetirementReason { get; set; }
1419

1520
}
1621
}

DigitalLearningSolutions.Web/Controllers/LearningPortalController/Current.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ public async Task<IActionResult> Current(
4444

4545
var centreId = User.GetCentreIdKnownNotNull();
4646
var selfAssessments =
47-
selfAssessmentService.GetSelfAssessmentsForCandidate(delegateUserId, centreId, 0);
47+
selfAssessmentService.GetSelfAssessmentsForCandidate(delegateUserId, centreId, 0)
48+
.Where(r => (r.RetirementDate != null && r.RetirementDate.Value.Date >= DateTime.UtcNow.Date)
49+
|| r.RetirementDate == null).ToList();
4850

4951
var (learningResources, apiIsAccessible) =
5052
await GetIncompleteActionPlanResourcesIfSignpostingEnabled(delegateUserId);

0 commit comments

Comments
 (0)