Merge pull request #2736 from TechnologyEnhancedLearning/Develop/Fixes/TD-4244-AddedHiddenInLearningPortalTabForInactive

TD-4244 Added hidden in learning portal added for inactive courses as well

Author: rshrirohit

DigitalLearningSolutions.Web/Helpers/FilterableTagHelper.cs

@@ -104,16 +104,13 @@ CourseStatistics courseStatistics
             {
                 tags.Add(new SearchableTagViewModel(CourseStatusFilterOptions.IsInactive));
             }
-            if (courseStatistics.Active)
+            if (courseStatistics.HideInLearnerPortal)
             {
-                if (courseStatistics.HideInLearnerPortal)
-                {
-                    tags.Add(new SearchableTagViewModel(CourseVisibilityFilterOptions.IsHiddenInLearningPortal));
-                }
-                else
-                {
-                    tags.Add(new SearchableTagViewModel(CourseVisibilityFilterOptions.IsNotHiddenInLearningPortal));
-                }
+                tags.Add(new SearchableTagViewModel(CourseVisibilityFilterOptions.IsHiddenInLearningPortal));
+            }
+            else
+            {
+                tags.Add(new SearchableTagViewModel(CourseVisibilityFilterOptions.IsNotHiddenInLearningPortal));
             }
             return tags;
         }
@@ -235,7 +232,7 @@ public static IEnumerable<SearchableTagViewModel> GetCurrentTagsForSelfAssessmen
              ? new SearchableTagViewModel(SelfAssessmentSignedOffFilterOptions.SignedOff)
              : new SearchableTagViewModel(SelfAssessmentSignedOffFilterOptions.NotSignedOff);
                 tags.Add(signedOffTag);
-                
+
             }
 
             return tags;