Skip to content

Commit e106cef

Browse files
authored
Merge pull request #2441 from TechnologyEnhancedLearning/Develop/Fixes/TD-3032-renamingassessmentsonLearningPortal
TD-3032 Following right format in naming the export file
2 parents 5517ff9 + 15273f8 commit e106cef

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

DigitalLearningSolutions.Data/DataServices/SelfAssessmentDataService/CandidateAssessmentsDataService.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ FROM SelfAssessmentSupervisorRoles AS SelfAssessmentSupervisorRoles_1
9898
'Supervisor') AS SignOffRoleName,
9999
SA.SignOffRequestorStatement,
100100
SA.ManageSupervisorsDescription,
101-
CA.NonReportable
101+
CA.NonReportable,
102+
U.FirstName +' '+ U.LastName AS DelegateName
102103
FROM CandidateAssessments CA
103104
JOIN SelfAssessments SA
104105
ON CA.SelfAssessmentID = SA.ID
@@ -110,6 +111,8 @@ INNER JOIN CompetencyGroups AS CG
110111
ON SAS.CompetencyGroupID = CG.ID AND SAS.SelfAssessmentID = @selfAssessmentId
111112
LEFT OUTER JOIN CandidateAssessmentOptionalCompetencies AS CAOC
112113
ON CA.ID = CAOC.CandidateAssessmentID AND C.ID = CAOC.CompetencyID AND CG.ID = CAOC.CompetencyGroupID
114+
INNER JOIN Users AS U
115+
ON U.ID = CA.DelegateUserID
113116
WHERE CA.DelegateUserID = @delegateUserId AND CA.SelfAssessmentID = @selfAssessmentId AND CA.RemovedDate IS NULL
114117
AND CA.CompletedDate IS NULL AND ((SAS.Optional = 0) OR (CAOC.IncludedInSelfAssessment = 1))
115118
GROUP BY
@@ -120,7 +123,8 @@ GROUP BY
120123
CA.ID, CA.UserBookmark, CA.UnprocessedUpdates,
121124
CA.LaunchCount, CA.SubmittedDate, SA.LinearNavigation, SA.UseDescriptionExpanders,
122125
SA.ManageOptionalCompetenciesPrompt, SA.SupervisorSelfAssessmentReview, SA.SupervisorResultsReview,
123-
SA.ReviewerCommentsLabel,SA.EnforceRoleRequirementsForSignOff, SA.ManageSupervisorsDescription,CA.NonReportable",
126+
SA.ReviewerCommentsLabel,SA.EnforceRoleRequirementsForSignOff, SA.ManageSupervisorsDescription,CA.NonReportable,
127+
U.FirstName , U.LastName",
124128
new { delegateUserId, selfAssessmentId }
125129
);
126130
}

DigitalLearningSolutions.Data/Models/SelfAssessments/CurrentSelfAssessment.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,6 @@ public class CurrentSelfAssessment : SelfAssessment
2222
public bool NonReportable { get; set; }
2323
public int? SupervisorCount { get; set; }
2424
public bool IsSameCentre { get; set; }
25+
public string? DelegateName { get; set; }
2526
}
2627
}

DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1536,11 +1536,11 @@ public IActionResult SignOffHistory(int selfAssessmentId, string vocabulary)
15361536
};
15371537
return View("SelfAssessments/SignOffHistory", model);
15381538
}
1539-
public IActionResult ExportCandidateAssessment(int candidateAssessmentId, string vocabulary,string candidateAssessmentName)
1539+
public IActionResult ExportCandidateAssessment(int candidateAssessmentId,string candidateAssessmentName, string delegateName)
15401540
{
15411541
var content = candidateAssessmentDownloadFileService.GetCandidateAssessmentDownloadFileForCentre(candidateAssessmentId, User.GetUserIdKnownNotNull(), true);
1542-
var fileName = $"{((candidateAssessmentName.Length > 30) ? candidateAssessmentName.Substring(0, 30) : candidateAssessmentName)} {vocabulary} Assessment Export {clockUtility.UtcNow:yyyy-MM-dd}.xlsx";
1543-
return File(
1542+
var fileName = $"{((candidateAssessmentName.Length > 30) ? candidateAssessmentName.Substring(0, 30) : candidateAssessmentName)} - {delegateName} - {clockUtility.UtcNow:yyyy-MM-dd}.xlsx";
1543+
return File(
15441544
content,
15451545
FileHelper.GetContentTypeFromFileName(fileName),
15461546
fileName

DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/_OverviewActionButtons.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<a class="nhsuk-button nhsuk-button--secondary"
2525
asp-route-candidateAssessmentId="@Model.SelfAssessment.CandidateAssessmentId"
2626
asp-route-candidateAssessmentName="@Model.SelfAssessment.Name"
27-
asp-route-vocabulary="@Model.VocabPlural()"
27+
asp-route-delegateName="@Model.SelfAssessment.DelegateName"
2828
asp-action="ExportCandidateAssessment"
2929
role="button">
3030
Export to Excel

0 commit comments

Comments
 (0)