TD-4887-code optimized

Author: Auldrin-Possa

DigitalLearningSolutions.Data/DataServices/SelfAssessmentDataService/SelfAssessmentSupervisorDataService.cs

@@ -103,9 +103,6 @@ public IEnumerable<SelfAssessmentSupervisor> GetOtherSupervisorsForCandidate(
             int delegateUserId
         )
         {
-            var selfAssessmentCategoryId = connection.ExecuteScalar<int>(@"SELECT CategoryID FROM SelfAssessments WHERE ID = @selfAssessmentId",
-                    new { selfAssessmentId });
-
             return connection.Query<SelfAssessmentSupervisor>(
                 @"SELECT DISTINCT
                     sd.ID AS SupervisorDelegateID,
@@ -125,9 +122,9 @@ FROM SupervisorDelegates AS sd
                 WHERE (sd.Removed IS NULL) AND (cas.Removed IS NULL) AND (sd.SupervisorAdminID IS NOT NULL) AND (sd.DelegateUserID = @delegateUserId)
 		            AND (au.Supervisor = 1 OR au.NominatedSupervisor = 1) AND (au.Active = 1)
 		            AND (ca.SelfAssessmentID <> @selfAssessmentId)
-                    AND (au.CategoryID = 0 OR au.CategoryID = @selfAssessmentCategoryId)
+                    AND (au.CategoryID = 0 OR au.CategoryID IN (select CategoryID from SelfAssessments where ID = @selfAssessmentId))
                 ORDER BY SupervisorName",
-                new { selfAssessmentId, delegateUserId, selfAssessmentCategoryId }
+                new { selfAssessmentId, delegateUserId }
             );
         }