TD-4092 Refactor DLS Competency Self Assessment Certificates to improve maintainability and security

Author: sherif-olaboye

DigitalLearningSolutions.Web/Controllers/LearningPortalController/Current.cs

@@ -22,7 +22,7 @@
     using DigitalLearningSolutions.Web.ViewModels.LearningPortal.Current;
     using DocumentFormat.OpenXml.EMMA;
     using Microsoft.AspNetCore.Mvc;
-      using Microsoft.Extensions.Logging;
+    using Microsoft.Extensions.Logging;
     using Microsoft.FeatureManagement.Mvc;
 
     public partial class LearningPortalController

DigitalLearningSolutions.Web/Services/SelfAssessmentService.cs

@@ -144,7 +144,7 @@ public int GetSelfAssessmentActivityDelegatesExportCount(string searchString, st
         public int? GetDelegateAccountId(int centreId, int delegateUserId);
         int CheckDelegateSelfAssessment(int candidateAssessmentsId);
         IEnumerable<CompetencyCountSelfAssessmentCertificate> GetCompetencyCountSelfAssessmentCertificate(int candidateAssessmentID);
-        CompetencySelfAssessmentCertificate GetCompetencySelfAssessmentCertificate(int candidateAssessmentID);
+        CompetencySelfAssessmentCertificate? GetCompetencySelfAssessmentCertificate(int candidateAssessmentID);
         CompetencySelfAssessmentCertificate? GetCompetencySelfAssessmentCertificate(int selfassessmentId, int userId);
         IEnumerable<Accessor> GetAccessor(int selfAssessmentId, int delegateUserID);
         ActivitySummaryCompetencySelfAssesment GetActivitySummaryCompetencySelfAssesment(int CandidateAssessmentSupervisorVerificationsId);
@@ -525,7 +525,7 @@ public IEnumerable<CompetencyCountSelfAssessmentCertificate> GetCompetencyCountS
         {
             return selfAssessmentDataService.GetCompetencyCountSelfAssessmentCertificate(candidateAssessmentID);
         }
-        public CompetencySelfAssessmentCertificate GetCompetencySelfAssessmentCertificate(int candidateAssessmentID)
+        public CompetencySelfAssessmentCertificate? GetCompetencySelfAssessmentCertificate(int candidateAssessmentID)
         {
             return selfAssessmentDataService.GetCompetencySelfAssessmentCertificate(candidateAssessmentID);
         }