TD-4502 Removing password check from the where condition

sherif-olaboye · sherif-olaboye · commit e8417c9f976c · 2024-08-21T11:17:10.000+01:00
diff --git a/DigitalLearningSolutions.Web/Services/UserService.cs b/DigitalLearningSolutions.Web/Services/UserService.cs
@@ -275,7 +275,7 @@ public void UpdateFailedLoginCount(UserAccount userAccount)
         public IEnumerable<DelegateUserCard> GetDelegateUserCardsForWelcomeEmail(int centreId)
         {
             return userDataService.GetDelegateUserCardsByCentreId(centreId).Where(
-                user => user.Approved && !user.SelfReg && (string.IsNullOrEmpty(user.Password) || !string.IsNullOrEmpty(user.Password)) &&
+                user => user.Approved && !user.SelfReg && 
                         !string.IsNullOrEmpty(user.EmailAddress)
                         && !Guid.TryParse(user.EmailAddress, out _)
                         && user.RegistrationConfirmationHash != null

Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ public void UpdateFailedLoginCount(UserAccount userAccount)`
`275`	`275`	`public IEnumerable<DelegateUserCard> GetDelegateUserCardsForWelcomeEmail(int centreId)`
`276`	`276`	`{`
`277`	`277`	`return userDataService.GetDelegateUserCardsByCentreId(centreId).Where(`
`278`		`- user => user.Approved && !user.SelfReg && (string.IsNullOrEmpty(user.Password) \|\| !string.IsNullOrEmpty(user.Password)) &&`
	`278`	`+ user => user.Approved && !user.SelfReg &&`
`279`	`279`	`!string.IsNullOrEmpty(user.EmailAddress)`
`280`	`280`	`&& !Guid.TryParse(user.EmailAddress, out _)`
`281`	`281`	`&& user.RegistrationConfirmationHash != null`