TD-4092 Changing 404 code to 401

sherif-olaboye · sherif-olaboye · commit f1e2b05afdf0 · 2024-08-21T15:36:51.000+01:00
diff --git a/DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs b/DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
@@ -1647,7 +1647,7 @@ public IActionResult CompetencySelfAssessmentCertificate(int selfAssessmentId, s
 
             if (!CertificateHelper.CanViewCertificate(recentResults, supervisorSignOffs))
             {
-                return NotFound();
+                return RedirectToAction("StatusCode", "LearningSolutions", new { code = 401 });
             }
 
             var competencycount = selfAssessmentService.GetCompetencyCountSelfAssessmentCertificate(competencymaindata.CandidateAssessmentID);
diff --git a/DigitalLearningSolutions.Web/Controllers/SupervisorController/Supervisor.cs b/DigitalLearningSolutions.Web/Controllers/SupervisorController/Supervisor.cs
@@ -1383,7 +1383,7 @@ public IActionResult CompetencySelfAssessmentCertificatesupervisor(int candidate
             var supervisorSignOffs = selfAssessmentService.GetSupervisorSignOffsForCandidateAssessment(competencymaindata.SelfAssessmentID, delegateUserId);
             if (!CertificateHelper.CanViewCertificate(recentResults, supervisorSignOffs))
             {
-                return NotFound();
+                return RedirectToAction("StatusCode", "LearningSolutions", new { code = 401 });
             }
 
             var competencycount = selfAssessmentService.GetCompetencyCountSelfAssessmentCertificate(competencymaindata.CandidateAssessmentID);

Original file line number	Diff line number	Diff line change
`@@ -1647,7 +1647,7 @@ public IActionResult CompetencySelfAssessmentCertificate(int selfAssessmentId, s`
`1647`	`1647`
`1648`	`1648`	`if (!CertificateHelper.CanViewCertificate(recentResults, supervisorSignOffs))`
`1649`	`1649`	`{`
`1650`		`- return NotFound();`
	`1650`	`+ return RedirectToAction("StatusCode", "LearningSolutions", new { code = 401 });`
`1651`	`1651`	`}`
`1652`	`1652`
`1653`	`1653`	`var competencycount = selfAssessmentService.GetCompetencyCountSelfAssessmentCertificate(competencymaindata.CandidateAssessmentID);`
Original file line number	Diff line number	Diff line change
`@@ -1383,7 +1383,7 @@ public IActionResult CompetencySelfAssessmentCertificatesupervisor(int candidate`
`1383`	`1383`	`var supervisorSignOffs = selfAssessmentService.GetSupervisorSignOffsForCandidateAssessment(competencymaindata.SelfAssessmentID, delegateUserId);`
`1384`	`1384`	`if (!CertificateHelper.CanViewCertificate(recentResults, supervisorSignOffs))`
`1385`	`1385`	`{`
`1386`		`- return NotFound();`
	`1386`	`+ return RedirectToAction("StatusCode", "LearningSolutions", new { code = 401 });`
`1387`	`1387`	`}`
`1388`	`1388`
`1389`	`1389`	`var competencycount = selfAssessmentService.GetCompetencyCountSelfAssessmentCertificate(competencymaindata.CandidateAssessmentID);`