Merge pull request #2131 from TechnologyEnhancedLearning/Develop/Features/TD-2506-Fix-use-of-async-void-in-ValidateAllowedDlsSubApplication.cs

TD-2506: Fix use of async void in ValidateAllowedDlsSubApplication.cs

Author: kevwhitt-hee

DigitalLearningSolutions.Web/ServiceFilter/ValidateAllowedDlsSubApplication.cs

@@ -32,7 +32,7 @@ public ValidateAllowedDlsSubApplication(
 
         public void OnActionExecuted(ActionExecutedContext context) { }
 
-        public async void OnActionExecuting(ActionExecutingContext context)
+        public  void OnActionExecuting(ActionExecutingContext context)
         {
             var user = context.HttpContext.User;
             if (!user.Identity.IsAuthenticated)
@@ -48,7 +48,7 @@ public async void OnActionExecuting(ActionExecutingContext context)
                 return;
             }
 
-            if (application == null || await ApplicationIsInaccessibleByPage(application!))
+            if (application == null || Task.Run(() => ApplicationIsInaccessibleByPage(application!)).Result)
             {
                 SetNotFoundResult(context);
                 return;