Skip to content

Commit f92714d

Browse files
committed
Fixes cancel upload and validation message
1 parent 8595527 commit f92714d

File tree

2 files changed

+19
-8
lines changed

2 files changed

+19
-8
lines changed

DigitalLearningSolutions.Web/Controllers/FrameworksController/ImportCompetencies.cs

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
using System.Collections.Generic;
1111
using System.IO;
1212
using System.Linq;
13+
using System.Linq.Expressions;
1314

1415
namespace DigitalLearningSolutions.Web.Controllers.FrameworksController
1516
{
@@ -278,15 +279,25 @@ public IActionResult UploadResults()
278279
return View("Developer/Import/UploadResults", model);
279280
}
280281
[Route("CancelImport")]
281-
public IActionResult CancelImport()
282+
public IActionResult CancelImport(int? frameworkId)
282283
{
283-
var data = GetBulkUploadData();
284-
var frameworkId = data.FrameworkId;
285-
if (!string.IsNullOrWhiteSpace(data.CompetenciesFileName))
284+
try
286285
{
287-
FileHelper.DeleteFile(webHostEnvironment, data.CompetenciesFileName);
286+
var data = GetBulkUploadData();
287+
frameworkId = data.FrameworkId;
288+
if (!string.IsNullOrWhiteSpace(data.CompetenciesFileName))
289+
{
290+
FileHelper.DeleteFile(webHostEnvironment, data.CompetenciesFileName);
291+
}
292+
}
293+
catch
294+
{
295+
296+
}
297+
finally
298+
{
299+
TempData.Clear();
288300
}
289-
TempData.Clear();
290301
return RedirectToAction("ViewFramework", new { frameworkId, tabname = "Structure" });
291302
}
292303
private void setupBulkUploadData(int frameworkId, int adminUserID, string competenciessFileName, string tabName, bool isNotBlank)

DigitalLearningSolutions.Web/ViewModels/Frameworks/Import/ImportCompetenciesFormData.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66

77
public class ImportCompetenciesFormData
88
{
9-
[Required(ErrorMessage = "Import competencies file is required")]
10-
[AllowedExtensions([".xlsx"], "Import competencies file must be in xlsx format")]
9+
[Required(ErrorMessage = "Import file is required")]
10+
[AllowedExtensions([".xlsx"], "Import file must be in xlsx format")]
1111
[MaxFileSize(5 * 1024 * 1024, "Maximum allowed file size is 5MB")]
1212
public IFormFile? ImportFile { get; set; }
1313
}

0 commit comments

Comments
 (0)