TD-3906 RegisterDelegateByCentreController - refactor (Controller-Service-Repository pattern)

Author: sherif-olaboye

DigitalLearningSolutions.Web.Tests/Controllers/Register/RegisterDelegateByCentreControllerTests.cs

@@ -2,7 +2,6 @@
 {
     using System;
     using System.Reflection;
-    using DigitalLearningSolutions.Data.DataServices.UserDataService;
     using DigitalLearningSolutions.Data.Enums;
     using DigitalLearningSolutions.Data.Exceptions;
     using DigitalLearningSolutions.Data.Models.Centres;
@@ -37,7 +36,6 @@ public class RegisterDelegateByCentreControllerTests
         private IJobGroupsService jobGroupsService = null!;
         private PromptsService promptsService = null!;
         private IRegistrationService registrationService = null!;
-        private IUserDataService userDataService = null!;
         private IUserService userService = null!;
         private IClockUtility clockUtility = null!;
         private IMultiPageFormService multiPageFormService = null!;
@@ -47,7 +45,6 @@ public class RegisterDelegateByCentreControllerTests
         public void Setup()
         {
             jobGroupsService = A.Fake<IJobGroupsService>();
-            userDataService = A.Fake<IUserDataService>();
             userService = A.Fake<IUserService>();
             promptsService = A.Fake<PromptsService>();
             cryptoService = A.Fake<ICryptoService>();
@@ -62,7 +59,6 @@ public void Setup()
                     jobGroupsService,
                     promptsService,
                     cryptoService,
-                    userDataService,
                     registrationService,
                     config,
                     clockUtility,
@@ -145,7 +141,7 @@ public void PersonalInformationPost_updates_tempdata_correctly()
                 Centre = 1,
             };
             A.CallTo(
-                    () => userDataService.CentreSpecificEmailIsInUseAtCentre(
+                    () => userService.CentreSpecificEmailIsInUseAtCentre(
                         model.CentreSpecificEmail!,
                         model.Centre.Value
                     )

DigitalLearningSolutions.Web/Controllers/Register/RegisterDelegateByCentreController.cs

@@ -2,8 +2,6 @@ namespace DigitalLearningSolutions.Web.Controllers.Register
 {
     using System;
     using System.Collections.Generic;
-    using DigitalLearningSolutions.Data.DataServices;
-    using DigitalLearningSolutions.Data.DataServices.UserDataService;
     using DigitalLearningSolutions.Data.Enums;
     using DigitalLearningSolutions.Data.Exceptions;
     using DigitalLearningSolutions.Data.Extensions;
@@ -38,7 +36,6 @@ public class RegisterDelegateByCentreController : Controller
         private readonly IJobGroupsService jobGroupsService;
         private readonly PromptsService promptsService;
         private readonly IRegistrationService registrationService;
-        private readonly IUserDataService userDataService;
         private readonly IClockUtility clockUtility;
         private readonly IUserService userService;
         private readonly IMultiPageFormService multiPageFormService;
@@ -48,7 +45,6 @@ public RegisterDelegateByCentreController(
             IJobGroupsService jobGroupsService,
             PromptsService promptsService,
             ICryptoService cryptoService,
-            IUserDataService userDataService,
             IRegistrationService registrationService,
             IConfiguration config,
             IClockUtility clockUtility,
@@ -59,7 +55,6 @@ IGroupsService groupsService
         {
             this.jobGroupsService = jobGroupsService;
             this.promptsService = promptsService;
-            this.userDataService = userDataService;
             this.registrationService = registrationService;
             this.cryptoService = cryptoService;
             this.config = config;