TD-2186: Removed use of async void

sarathlal-sarangadharan · sarathlal-sarangadharan · commit ff3cb702b106 · 2023-09-12T17:44:47.000+01:00
diff --git a/DigitalLearningSolutions.Web/Services/DelegateDownloadFileService.cs b/DigitalLearningSolutions.Web/Services/DelegateDownloadFileService.cs
@@ -133,7 +133,7 @@ private void PopulateJobGroupsSheet(IXLWorkbook workbook)
             ClosedXmlHelper.AddSheetToWorkbook(workbook, JobGroupsSheetName, jobGroups, TableTheme);
         }
 
-        private async void PopulateAllDelegatesSheet(
+        private void PopulateAllDelegatesSheet(
             IXLWorkbook workbook,
             int centreId,
             string? searchString,
@@ -143,7 +143,7 @@ private async void PopulateAllDelegatesSheet(
         )
         {
             var registrationPrompts = centreRegistrationPromptsService.GetCentreRegistrationPromptsByCentreId(centreId);
-            var delegatesToExport = await GetDelegatesToExport(centreId);
+            var delegatesToExport =  Task.Run(() => GetDelegatesToExport(centreId)).Result; 
             var searchedUsers = GenericSearchHelper.SearchItems(delegatesToExport, searchString).AsQueryable();
             var filteredItems = FilteringHelper.FilterItems(searchedUsers, filterString).AsQueryable();
             var sortedItems = GenericSortingHelper.SortAllItems(

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ private void PopulateJobGroupsSheet(IXLWorkbook workbook)`
`133`	`133`	`ClosedXmlHelper.AddSheetToWorkbook(workbook, JobGroupsSheetName, jobGroups, TableTheme);`
`134`	`134`	`}`
`135`	`135`
`136`		`- private async void PopulateAllDelegatesSheet(`
	`136`	`+ private void PopulateAllDelegatesSheet(`
`137`	`137`	`IXLWorkbook workbook,`
`138`	`138`	`int centreId,`
`139`	`139`	`string? searchString,`
`@@ -143,7 +143,7 @@ private async void PopulateAllDelegatesSheet(`
`143`	`143`	`)`
`144`	`144`	`{`
`145`	`145`	`var registrationPrompts = centreRegistrationPromptsService.GetCentreRegistrationPromptsByCentreId(centreId);`
`146`		`- var delegatesToExport = await GetDelegatesToExport(centreId);`
	`146`	`+ var delegatesToExport = Task.Run(() => GetDelegatesToExport(centreId)).Result;`
`147`	`147`	`var searchedUsers = GenericSearchHelper.SearchItems(delegatesToExport, searchString).AsQueryable();`
`148`	`148`	`var filteredItems = FilteringHelper.FilterItems(searchedUsers, filterString).AsQueryable();`
`149`	`149`	`var sortedItems = GenericSortingHelper.SortAllItems(`