Skip to content

Conversation

@rshrirohit
Copy link
Collaborator

@rshrirohit rshrirohit commented Nov 7, 2024

JIRA link

TD-4773

Description

Screenshots


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

sherif-olaboye and others added 30 commits October 1, 2024 11:48
…cking system - Centre administrators' screen
…s/TD-4755-MyAccount-ActivevalueislistedasoneoftheAdminroles

TD-4755 My Account - Active value is listed as one of the Admin roles
…TD-4785-Duplicates-in-Supervisor-dashboard

TD-4785- Removed date updated to CandidateAssessmentSupervisors table.
…ster using a predetermined email address without additional approval steps
…ster using a predetermined email address without additional approval steps
…d SelfAssessmentOverview with optional competencies
…s/TD-4471-Issueswith'Search'functionalitywhenJSturnedoffon'Trackingsystem-Centreadministrators'screen

TD-4471 Issues with 'Search' functionality when JS turned off on 'Tracking system - Centre administrators' screen
…TD-4787-NominatedSupervisors-change-role-Assessor

TD-4787-Changed role from Educator/Manager to Assessor for nominated supervisors.
…TD-4785-Duplicates-in-Supervisor-dashboard

TD-4785-Set the Removed date as the current date for old duplicate rows in the table
…ure/TD-4793-unit-tests-to-deactivate-adminaccount-ifexists

TD-4793-Unit tests added for deactivate delegate controller
…ure/TD-4789-unit-tests-tags-added-on-optional-competencies-learner-view

TD-4789-Unit tests added for ManageOptionalCompetencies with flags and SelfAssessmentOverview with optional competencies
…delegate matches the user Id of the admin record of the supervisor being selected.
…ameRevert

Reverting the X-Frame-Options change
rshrirohit and others added 22 commits October 28, 2024 10:26
…s/TD-4920-Fix-optional-competency-frontend

TD-4920 Fix optional competency frontend
…ure/TD-4791-unit-tests-filter-added-on-optional-competencies-learner-view

TD-4791-Unit tests added for filter on optional competencies in the learner view.
…ures/TD-4751-FlagSelfAssessmentNonReportable

Mark the Non Reportable flag as true when the user Id of the delegate matches the user Id of the admin record of the supervisor being selected.
…tures/TD-4790-Writeunittestsfortagsaddedonoptionalcompetenciesinthesupervisorview
…TD-4946-email-address-displayed-twice

TD-4946-Name property initialized from UserAccount entity
…tures/TD-4632-Asacentremanageratanewcentre,Ishouldbeabletoregisterusingapredeterminedemailaddresswithoutadditionalapprovalsteps
…tures/TD-4632-Asacentremanageratanewcentre,Ishouldbeabletoregisterusingapredeterminedemailaddresswithoutadditionalapprovalsteps
…ures/TD-4632-Asacentremanageratanewcentre,Ishouldbeabletoregisterusingapredeterminedemailaddresswithoutadditionalapprovalsteps

TD-4632 As a centre manager at a new centre, I should be able to register using a predetermined email address without additional approval steps
…ures/TD-4790-Writeunittestsfortagsaddedonoptionalcompetenciesinthesupervisorview

TD-4790 Write unit tests for tags added on optional competencies in the supervisor view
…TD-4495-Issue-with-adding-the-filters

TD-4495-Issue with adding the filters on 'Centre administrators' screen for 'Bedfordshire Hospitals NHS Trust' centre
…ures/TD-4792-Warncentreadminsthatactiveadminaccountexistswheninactivatingdelegateaccount

TD-4792 Write unit tests for filter added on optional competencies in  the supervisor view
@rshrirohit rshrirohit marked this pull request as ready for review November 7, 2024 17:37
@rshrirohit rshrirohit changed the base branch from release-v1.0.0 to DLS-Release-v0.0.1 November 7, 2024 17:38
@rshrirohit rshrirohit closed this Nov 7, 2024
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-4773-GitHubActionsTargetToDotNet8 branch November 7, 2024 17:38
@rshrirohit rshrirohit removed the request for review from kevwhitt-hee November 7, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants