TD-4327-Code added to verify if supervisor delegate exists. #2934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… admin course category
… admin course category
…ures/TD-4879-LimittheselfassessmentsreturnedinDelegateActivitiesbyadmincoursecategory TD-4879 Limit the self assessments returned in Delegate Activities by admin course category
…ure/TD-4882-Limit-selfassessments-that-supervisor-enrol TD-4882-Limit the self assessments that a supervisor can enrol staff on to those matching their assigned category
…ure/TD-4878-Limit-the-list-of-supervisors TD-4878-Limit the list of supervisors returned in the Tracking System enrol on self assessment
…include only those in their assigned category
…thesupervisorMyStaffviewselfassessmentcountstoincludeonlythoseintheirassignedcategory
…n logged in supervisor category
…t CategoryID in the GetAllSupervisorsForSelfAssessmentId(+)
…ures/TD-4881-LimitthesupervisorMyStaffviewselfassessmentcountstoincludeonlythoseintheirassignedcategory TD-4881 Limit the supervisor My Staff view self assessment counts to include only those in their assigned category
…ure/TD-4883-Limit-the-SelfAssessments-returned-in-supervisor-View TD-4883-Limit the self assessments returned in the supervisor View self assessments view to those that match their assigned category
…ure/TD-4887-Limit-supervisors-ManageSupervisors-QuickAdd TD-4887- Limit the supervisors that are available in the Manage Supervisors "Quick add" list to supervisors with a category that matches the self assessment
…ure/TD-4888-Limit-supervisors-AddNewSupervisor TD-4888-Limit the supervisors that are available to add to self assessment from "Manage supervisors" to supervisors with a matching category
…ure/TD-4972-Limit-existing-supervisors-in-Manage-Supervisors TD-4972-Limit the list of existing supervisors in the Manage Supervisors list to supervisors with a matching category
…s/TD-4991-UpdatePRTemplate TD-4991 Updates the pull request template
…ure/TD-4974-Limit-supervisors-Request-sign-off TD-4974-Limit the list of supervisors in the Request sign off view to supervisors with a matching category
…sor role, assign them to the same category as the supervisor
…irmation view to supervisors with a matching category
…ure/TD-4975-Limit-supervisor-signoff-confirmation-Request TD-4975-Limit the supervisor task list to show only sign off and confirmation requests that are for self assessments that match the supervisors category
…ures/TD-4889-WhenasupervisorpromotesalearnertotheNominatedsupervisorrole,assignthemtothesamecategoryasthesupervisor TD-4889 When a supervisor promotes a learner to the Nominated supervisor role, assign them to the same category as the supervisor
…ures/TD-4973-LimitthelistofsupervisorsintheRequestproficiencyconfirmationviewtosupervisorswithamatchingcategory TD-4973 Limit the list of supervisors in the Request proficiency confirmation view to supervisors with a matching category
…n a category that doesn't match their own
…ures/TD-4884-Preventsupervisorsfromviewing/reviewingselfassessmentsinacategorythatdoesn'tmatchtheirowns TD-4884 Prevent supervisors from viewing/reviewing self assessments in a category that doesn't match their own
…elf assessments in a category that doesn't match their own through URL manipulation.
…pposed to be made for Delegate Activities and not Activity Delegates, adding specific logic to the Self Assessment service layer and showing Unauthorised activity based on return type.
…s/TD-5020-ResolvingBuildError TD-5020 Resolving build failure
…s/TD-4880-Prevent_Admin_View_ActivityDelegates Prevent administrators from viewing Activity Delegates for self assessments in a category that doesn't match their own
|
The PR looks ok |
kevwhitt-hee
force-pushed
the
DLS-Release-v1.1.0
branch
from
203ad52 to
43c8c53
Compare
|
branch code conflicts |
Auldrin-Possa
deleted the
Develop/Fix/TD-4327-Confirmation-link-other-centres-Issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
TD-4327
Description
Code added to verify if supervisor delegate exists.
Used existing error page, as there is 'Forbidden' error page is being used for 403 status code in the application.
Note - For centres with learner role only, an Access Denied page will be displayed.
Screenshots
Developer checks
I have: