Skip to content

Conversation

@sherif-olaboye
Copy link
Contributor

@sherif-olaboye sherif-olaboye commented Nov 19, 2024

JIRA link

https://hee-tis.atlassian.net/browse/TD-4340

Description

I check if SectionContentData is not null and check the count is more or greater than 3 to ensure it is not a new request,
I return SectionContentData for the multiPageFormService to prevent the user selecting the tutorials again

Screenshots

image
when I click the change from the summary page
image
image
image
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@kevwhitt-hee kevwhitt-hee merged commit 203ed0e into DLS-Release-v1.1.1 Nov 21, 2024
2 checks passed
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-4340-Issuewiththe'Coursecontent'changelinkwhencreatingacoursefrom'Coursesetup'screen branch November 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants