Skip to content

Conversation

@ABSinhaa
Copy link
Contributor

@ABSinhaa ABSinhaa commented Dec 27, 2024

JIRA link

TD-5185

Description

Added a PropertyGroup variable called OutputType and set it to Library since Integration.Tests is a test project. Updated the xunit and xunit.runner.visualstudio to their latest stable versions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

…get package when upgraded to version 3.0.0 by dependabot.
@ABSinhaa ABSinhaa marked this pull request as ready for review December 27, 2024 13:57
@rshrirohit rshrirohit closed this Jan 24, 2025
@rshrirohit rshrirohit deleted the Develop/fixes/TD-5185_Investigate_Build_Failure branch January 24, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants