Skip to content

TD-5188 Investigate the build failure for the dependabot Pull Request #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

TD-5188 Investigate the build failure for the dependabot Pull Request #3041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
802ec20
TD-5188 Investigate the build failure for the dependabot Pull Request
sherif-olaboye Dec 30, 2024
e6c4180
TD-5188 Investigate the build failure for the dependabot Pull Request
sherif-olaboye Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...arningSolutions.Web.AutomatedUiTests/DigitalLearningSolutions.Web.AutomatedUiTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="FluentAssertions" Version="5.10.3" />
<PackageReference Include="FluentAssertions" Version="7.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="7.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="Selenium.Axe" Version="4.0.21" />
Expand Down
2 changes: 1 addition & 1 deletion ...arningSolutions.Web.IntegrationTests/DigitalLearningSolutions.Web.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<ItemGroup>
<PackageReference Include="FakeItEasy" Version="7.4.0" />
<PackageReference Include="FluentAssertions.AspNetCore.Mvc" Version="3.2.0" />
<PackageReference Include="FluentAssertions.AspNetCore.Mvc" Version="4.1.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="7.0.0" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">
Expand Down
6 changes: 3 additions & 3 deletions DigitalLearningSolutions.Web.Tests/DigitalLearningSolutions.Web.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
Expand All @@ -9,8 +9,8 @@

<ItemGroup>
<PackageReference Include="FakeItEasy" Version="7.4.0" />
<PackageReference Include="FluentAssertions" Version="5.10.3" />
<PackageReference Include="FluentAssertions.AspNetCore.Mvc" Version="3.2.0" />
<PackageReference Include="FluentAssertions" Version="7.0.0" />
<PackageReference Include="FluentAssertions.AspNetCore.Mvc" Version="4.1.0" />
<PackageReference Include="NBuilder" Version="6.1.0" />
<PackageReference Include="NUnit" Version="3.14.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
Expand Down
2 changes: 1 addition & 1 deletion DigitalLearningSolutions.Web.Tests/Services/CentresServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public void GetCentreSummaryForFindContactDislay_calls_dataService_and_returns_o
var result = centresService.GetCentreSummaryForContactDisplay(selectedCenter);

// Then
result.Should().Equals(1);
result.Should().NotBeNull();
}

[Test]
Expand Down
2 changes: 1 addition & 1 deletion DigitalLearningSolutions.Web.Tests/TestHelpers/SessionTestHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public static Session CreateDefaultSession(

public static void SessionsShouldBeApproximatelyEquivalent(Session session1, Session session2)
{
const int tenSecondsInMilliseconds = 10000;
var tenSecondsInMilliseconds = TimeSpan.FromMilliseconds(10000);

session1.CandidateId.Should().Be(session2.CandidateId);
session1.CustomisationId.Should().Be(session2.CustomisationId);
Expand Down
Loading