Skip to content

Conversation

@sherif-olaboye
Copy link
Contributor

JIRA link

https://hee-tis.atlassian.net/browse/TD-5096

Description

I added the AdminCategoryId and CategoryId properties to the SelfAssessmentReportsViewModel class
I added the GetSelfAssessmentCategoryId to the index action method of the SelfAssessmentReportsController to get the DSAT CategoryId
I added a check to the index view to hide the link to the DSAT report if the AdminCategoryId did not match the CategoryId and the AdminCategoryId is not NULL

Screenshots

When the adminCategoryId is set to 4
image
When the adminCategoryId is set to 1
image
When the adminCategoryId is set to Null
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

Copy link
Collaborator

@rshrirohit rshrirohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevwhitt-hee please see the inline comment. @sherif-olaboye we would wait for Kevin's comment before making changes here, please.

@rshrirohit rshrirohit merged commit fc35590 into DLS-Release-v1.1.1 Jan 27, 2025
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Features/TD-5096-HidethelinktotheDSATreportftheadminuserisinacategorythatdoesn'tmatch branch January 27, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants