Skip to content

TD-5568 Add 'Last accessed date' to 'sort' filter on 'Tracking system - Delegates' screen #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

TD-5568 Add 'Last accessed date' to 'sort' filter on 'Tracking system - Delegates' screen #3260

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7246e0d
TD-5568 Add 'Last accessed date' to 'sort' filter on 'Tracking system…
sherif-olaboye May 12, 2025
6f9fb33
TD-5568 changing to Last Accessed Date to Last accessed date
sherif-olaboye May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions DigitalLearningSolutions.Data/DataServices/UserDataService/DelegateUserCardDataService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,8 @@ public List<DelegateUserCard> GetDelegateUserCardsForExportByCentreId(String sea

if (sortBy == "SearchableName")
orderBy = " ORDER BY LTRIM(LastName) " + sortDirection + ", LTRIM(FirstName) ";
else if(sortBy == "LastAccessed")
orderBy = " ORDER BY LastAccessed " + sortDirection;
else
orderBy = " ORDER BY DateRegistered " + sortDirection;

Expand Down
3 changes: 3 additions & 0 deletions DigitalLearningSolutions.Data/Helpers/GenericSortingHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ public static class DelegateSortByOptions
public static readonly (string DisplayText, string PropertyName) Name =
("Name", nameof(DelegateUserCard.SearchableName));

public static readonly (string DisplayText, string PropertyName) LastAccessed =
("Last Accessed Date", nameof(DelegateUserCard.LastAccessed));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this consistent with the changes done in the other related tickets. 'Last accessed date'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


public static readonly (string DisplayText, string PropertyName) RegistrationDate =
("Registration Date", nameof(DelegateUserCard.DateRegistered));
}
Expand Down
1 change: 1 addition & 0 deletions ...ngSolutions.Web/ViewModels/TrackingSystem/Delegates/AllDelegates/AllDelegatesViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ IEnumerable<FilterModel> availableFilters
public override IEnumerable<(string, string)> SortOptions { get; } = new[]
{
DelegateSortByOptions.Name,
DelegateSortByOptions.LastAccessed,
DelegateSortByOptions.RegistrationDate,
};

Expand Down
Loading