TD-5307 Select competency framework source

[sherif-olaboye]

JIRA link

https://hee-tis.atlassian.net/browse/TD-5307

Description

I added a check to ensure that when a framework source is not selected, the user is notified
I also modified the SelfAssessmentFields query to remove framework sources that have already been removed from the competency assessment

Screenshots

before removing the framework source


when you click the add button without selecting any framework source

After removing the framework source

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
• Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
• Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
• Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
• Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
  Either:
• Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • doc_1_here
    Or:
• Confirmed that none of the work that I have undertaken requires any updates to documentation

[rshrirohit]

Issue 3 stated in the Jira ticket is not solved here, please could we solve for that as well?

[rshrirohit]

I took 1.3.0 branch and here is screenshot of frameworks -

Now selecting your branch -

see the frameworks vanished

[rshrirohit]

Instead of doing this, please do the validation in the Model (make the frameworkid nullable so that it can't accept zero as a value. you'll have to change in cshtml as well where a default value of zero is provided)

[sherif-olaboye]

Done

[sherif-olaboye]

Issue 3 stated in the Jira ticket is not solved here, please could we solve for that as well?

I could not replicate this issue

[sherif-olaboye]

I took 1.3.0 branch and here is screenshot of frameworks -

Now selecting your branch -

see the frameworks vanished

I have addressed this by checking and include None for compentency without linked framework