Skip to content

Commit 5c737c0

Browse files
committed
chore(tidying stuff): tidy
1 parent 2a878f4 commit 5c737c0

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ jobs:
9393

9494
- name: Debug Version Output BCL var
9595
run: echo "Extracted Version $BCL_VERSION "
96-
#qqqq are we a commit behind check that we use the new generated version of the package
96+
9797

9898
# the restore cant be given env values to override values like it can in build so we need to remove this file so we use the env values
9999
- name: Remove Local PackageSettings (CI Only)
@@ -111,8 +111,7 @@ jobs:
111111
112112
- name: Replace local environment variable in nuget config because cant provide it as a parameter
113113
run: sed -i "s|%LocalPackagePath%|$BCL_Local_Source|g" nuget.config
114-
115-
#qqqq ask binon about this
114+
116115
- name: Clean lock files because the newly generated package file will superseed the locks
117116
run: |
118117
find . -name "packages.lock.json" -type f -exec rm -f {} \;

Package.BlazorComponentLibrary/Package.BlazorComponentLibrary.csproj

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@
2424
<PackageLicenseExpression>MIT</PackageLicenseExpression>
2525
<RepositoryUrl>https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM</RepositoryUrl>
2626
<RepositoryType>git</RepositoryType>
27-
<!--<PackageReadmeFile>ReadMe.md</PackageReadmeFile> qqqq put in later just needs picking up-->
28-
<!--qqqq would have its own changelog genereate readme later anyway -->
29-
30-
<!--qqqq gitignored-->
27+
<!--<PackageReadmeFile>ReadMe.md</PackageReadmeFile> qqqqqqqq put in later just needs picking up-->
3128
<PackageOutputPath>$(NupkgOutputPath)</PackageOutputPath>
3229

3330
</PropertyGroup>

PackageSettings.props.local

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<NupkgOutputPath>C:\LocalDevelopmentPackageVersions</NupkgOutputPath>
77
<IsLocalDev>true</IsLocalDev>
88
<UseBCLProjectReference>false</UseBCLProjectReference>
9-
<!--qqqq come back to why did i stop using local env variable after git tags may want to rename this bclversionlocal and automate it with build number, and put a shared file so other solutions can use it like lh with now version updates in development-->
9+
<!--qqqqqq come back to why did i stop using local env variable after git tags may want to rename this bclversionlocal and automate it with build number, and put a shared file so other solutions can use it like lh with now version updates in development-->
1010
<BCLVersion>3.0.2</BCLVersion>
1111
</PropertyGroup>
1212
</Project>

0 commit comments

Comments
 (0)