Skip to content

Commit 6187f8e

Browse files
authored
Merge pull request #39 from TechnologyEnhancedLearning/fix-pr-release-yml
Fix pr release yml
2 parents dc8d8c3 + 9794248 commit 6187f8e

File tree

2 files changed

+28
-15
lines changed

2 files changed

+28
-15
lines changed

.github/workflows/pull_request.yml

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
name: Pull Request Checks
2-
on:
3-
pull_request:
4-
# branches:
5-
# - '**'
6-
2+
3+
on: pull_request
74
jobs:
5+
86
branch-name-check:
97
name: Enforce Branch Name Convention
108
runs-on: ubuntu-latest
@@ -27,6 +25,7 @@ jobs:
2725
#continue-on-error: true
2826

2927
commitlint:
28+
name: commitlint
3029
# qqqq repo will need branch protection rules and PR Template
3130
runs-on: ubuntu-latest
3231
if: success() || failure()
@@ -41,6 +40,7 @@ jobs:
4140

4241

4342
gitguardian-scan:
43+
name: gitguardian
4444
runs-on: ubuntu-latest
4545
if: success() || failure()
4646
steps:
@@ -53,6 +53,7 @@ jobs:
5353
#continue-on-error: true # we dont want secrets going further and the keys need to be changed if this is triggered
5454

5555
Unit-Tests:
56+
name: todo unit tests
5657
runs-on: ubuntu-latest
5758
if: success() || failure()
5859
steps:
@@ -62,6 +63,7 @@ jobs:
6263

6364

6465
E2E-Tests:
66+
name: todo e2e tests
6567
runs-on: ubuntu-latest
6668
if: success() || failure()
6769
steps:
@@ -70,9 +72,27 @@ jobs:
7072
#continue-on-error: true
7173

7274
Code-Coverage:
75+
name: code coverage
7376
runs-on: ubuntu-latest
7477
if: success() || failure()
7578
steps:
7679
- name: Code Coverage
7780
run: echo "TODO Code Coverage"
7881
#continue-on-error: true
82+
83+
All-Checks-Passed:
84+
name: all checks passed
85+
runs-on: ubuntu-latest
86+
needs:
87+
- branch-name-check
88+
- commitlint
89+
- gitguardian-scan
90+
- Unit-Tests
91+
- E2E-Tests
92+
- Code-Coverage
93+
if: ${{ success() }}
94+
steps:
95+
- name: all checks passed steps
96+
run: echo "allow all checks to run incase multiple fails then fail here"
97+
98+

CHANGELOG.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
1-
# [9.1.0](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.0.0...v9.1.0) (2025-04-15)
1+
## [9.1.1-fix-pr-release-yml.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.0...v9.1.1-fix-pr-release-yml.1) (2025-04-15)
22

33

4-
### Features
4+
### Bug Fixes
55

6-
* **pr and rel:** to master ([25d0f7b](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/25d0f7bd4be8deebf4ac61922e2fb039ccf3b705))
7-
8-
# [9.1.0-feat-version-work-on-branch-maybe.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.0.0...v9.1.0-feat-version-work-on-branch-maybe.1) (2025-04-15)
9-
10-
11-
### Features
12-
13-
* **pr and rel:** to master ([25d0f7b](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/25d0f7bd4be8deebf4ac61922e2fb039ccf3b705))
6+
* **pr check:** check ([ae4bbad](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/ae4bbadd17de402900431967692b1d2792023318))

0 commit comments

Comments
 (0)