Merge pull request #41 from TechnologyEnhancedLearning/fix-quick-pr-run-now-in-master

Fix quick pr run now in master

Author: Phil-NHS

.github/workflows/dev.yml

@@ -174,7 +174,7 @@ jobs:
 
       # - name: debug github commands
         # run: |
-          # echo "but we want more complex versioning currently so wont use tag but will for release qqqq"
+          # echo "but we want more complex versioning currently so wont use tag but will for release"
           # echo "as we will name commits like fix(broken-thing): changed broken line, and branches fix/broken-thing  we should be able to use them in package names"
           # echo "branch tag $(git describe --tags --abbrev=0)"
           # echo "branch name $(git branch --show-current)"
@@ -518,16 +518,9 @@ jobs:
          # echo "BCLVersion: $BCL_VERSION"
          # echo "UseBCLProjectReference: $USE_BCL_PROJECT_REFERENCE"
 
-      # #qqqq not showing the value   
-      # - name: qqqq Display Directory.Packages.props
-        # run: |
-          # echo "if we can get this to say the version number then move it higher in the steps i think it may work"
-          # echo "we dont want this <PackageVersion Include="TELBlazorComponentLibrary.GitPageBlazorWasm" Version="$(BCLVersion)" />  "
-          # echo "try restore"
-          # dotnet Restore
-          # cat Directory.Packages.props
+
 
-      # - name: qqqq is it because solution level not receive /p for project so need githun_env values
+      # - name:  is it because solution level not receive /p for project so need githun_env values
         # run: |
          # echo "BCLVersion=$BCL_VERSION" >> $GITHUB_ENV
          # echo "LocalPackagePath=$BCL_SOURCE" >> $GITHUB_ENV
@@ -536,7 +529,7 @@ jobs:
          # echo "UseBCLProjectReference=$USE_BCL_PROJECT_REFERENCE" >> $GITHUB_ENV
          # #echo "GITHUB_PACKAGES_TOKEN=$PACKAGES_TOKEN" >> $GITHUB_ENV
 
-      # - name: qqqq now try restore again
+      # - name: now try restore again
         # run: |
          # dotnet Restore
          # cat Directory.Packages.props
@@ -545,39 +538,9 @@ jobs:
       # - name: Display Environment Variable (for debugging)
         # run: echo "BCLVERSION is $BCLVERSION"
 
-      # # - name: qqqqqqq here now try build
-        # # run: |
-          # # -e
-          # # dotnet build
-          # # cat Directory.Packages.props
-          # # echo "doesnt work"
-          # # +e
-
 
 
-          
-
-      # - name: Publish client using client release .csproj logic
-        # run: |
-          # dotnet publish ./TestHostPrerenderWASM/TestHostPrerenderWASM.Client/TestHostPrerenderWASM.Client.csproj --configuration Release \
-            # /p:IsLocalDev=$IS_LOCAL_DEV \
-            # /p:BCLVersion=$BCL_VERSION \
-            # /p:UseBCLProjectReference=$USE_BCL_PROJECT_REFERENCE
-            # /p:GhPageRelease=true
 
-
-      # #include hidden so we get jekyll
-      # - name: Creating artifact of publish folder for test gh page workflow
-        # uses: actions/upload-artifact@v4
-        # with:
-          # name: gh-blazor-components-wiki-site-using-package-${{env.BCL_VERSION}}
-          # include-hidden-files: true
-          # path: | 
-            # ./docs
-            # ./docs/.nojekyll  # explicitly include the .nojekyll file
-          # retention-days: 90
-          
-      
       # - name: Debug artifact location
         # run: |
           # # Get the artifact list for the current workflow run

.github/workflows/pull_request.yml

@@ -6,7 +6,7 @@ jobs:
   branch-name-check:
     name: Enforce Branch Name Convention
     runs-on: ubuntu-latest
-    if: success() || failure()
+    #if: success() || failure()
     steps:
       - name: Validate Branch Name
         run: |
@@ -28,7 +28,7 @@ jobs:
     name: commitlint
   # qqqq repo will need branch protection rules and PR Template
     runs-on: ubuntu-latest
-    if: success() || failure()
+    #if: success() || failure()
     steps:
       - uses: actions/checkout@v4
         with:
@@ -42,7 +42,7 @@ jobs:
   gitguardian-scan:
     name: gitguardian
     runs-on: ubuntu-latest
-    if: success() || failure()
+    #if: success() || failure()
     steps:
       - uses: actions/checkout@v3
 
@@ -55,7 +55,7 @@ jobs:
   Unit-Tests:
       name: todo unit tests
       runs-on: ubuntu-latest
-      if: success() || failure()
+      #if: success() || failure()
       steps:
         - name: See other project pipeline for Tests
           run: echo "qqqq See other project pipeline for Tests this is a placeholder"
@@ -65,7 +65,7 @@ jobs:
   E2E-Tests:
       name: todo e2e tests
       runs-on: ubuntu-latest
-      if: success() || failure()
+      #if: success() || failure()
       steps:
         - name: See other project pipeline for Tests
           run: echo "qqqq See other project pipeline for Tests this is a placeholder"
@@ -74,7 +74,7 @@ jobs:
   Code-Coverage:
       name: code coverage
       runs-on: ubuntu-latest
-      if: success() || failure()
+      #if: success() || failure()
       steps:
         - name: Code Coverage
           run: echo "TODO Code Coverage"

CHANGELOG.md

@@ -1,27 +1,6 @@
-## [9.1.2](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.1...v9.1.2) (2025-04-15)
+## [9.1.3-fix-quick-pr-run-now-in-master.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.2...v9.1.3-fix-quick-pr-run-now-in-master.1) (2025-04-15)
 
 
 ### Bug Fixes
 
-* **go:** go ([4690ddd](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/4690ddd92bf69a712899c6a75ca0c945b4b73fc3))
-
-## [9.1.2-fix-quick-pr-run-now-in-master.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.1...v9.1.2-fix-quick-pr-run-now-in-master.1) (2025-04-15)
-
-
-### Bug Fixes
-
-* **go:** go ([4690ddd](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/4690ddd92bf69a712899c6a75ca0c945b4b73fc3))
-
-## [9.1.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.0...v9.1.1) (2025-04-15)
-
-
-### Bug Fixes
-
-* **pr check:** check ([ae4bbad](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/ae4bbadd17de402900431967692b1d2792023318))
-
-## [9.1.1-fix-pr-release-yml.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.0...v9.1.1-fix-pr-release-yml.1) (2025-04-15)
-
-
-### Bug Fixes
-
-* **pr check:** check ([ae4bbad](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/ae4bbadd17de402900431967692b1d2792023318))
+* **pull request visible check:** go ([d29ba68](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/d29ba686f77de02052b1ee79c18a73e8d71a63ee))

Package.BlazorComponentLibrary/Package.BlazorComponentLibrary.csproj

@@ -41,7 +41,6 @@
 		<Content Remove="packages.lock.json" />
 		<Content Remove="wwwroot\background.png" />
 	</ItemGroup>
-	<!--qqqq building in the solution wasnt an issue before-->
 	<ItemGroup>
 		<Compile Remove="..\CICDPackageLocation\**\*.cs" />
 		<Content Remove="..\CICDPackageLocation\**\*" />

ReadMe.md

@@ -2,8 +2,6 @@
 
 
 
-## qqqq unlike in nuget feed git package feed doesnt display this file so to see it you need to look in the actual nuget package
-
 # Local Development
 - inc the version in local props
 	- save

SharedPages/wwwroot/css/app.css

@@ -75,5 +75,5 @@
 code {
     color: #c02d76;
 }
-/* RCL Styles qqqq remember bundled scoped css we may not use it but it is extremely normal to so we may in future*/
+/* RCL Styles remember bundled scoped css we may not use it but it is extremely normal to so we may in future*/
 @import '_content/Package.BlazorComponentLibrary/Package.BlazorComponentLibrary.bundle.scp.css';