diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 1da4198..1a81cc7 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -15,7 +15,7 @@ jobs: BRANCH_NAME="${GITHUB_HEAD_REF:-${GITHUB_REF_NAME}}" echo "Validating branch name: $BRANCH_NAME" - if [[ "$BRANCH_NAME" =~ ^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|sample|security|config|bugfix|hotfix)-[a-zA-Z0-9._/-]+$ ]] || [[ "$BRANCH_NAME" == "master" ]]; then + if [[ "$BRANCH_NAME" =~ ^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|sample|security|config|bugfix|hotfix)-[a-zA-Z0-9._/-]+$ ]] || [[ "$BRANCH_NAME" == "master" ]] || [[ "$BRANCH_NAME" == "Automatic_version_update_dependabot" ]]; then echo "✅ Branch name is valid" else echo "❌ Invalid branch name: $BRANCH_NAME" diff --git a/CHANGELOG.md b/CHANGELOG.md index afc4552..0f179e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,30 +1,7 @@ -## [9.2.4](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.2.3...v9.2.4) (2025-04-22) +## [9.2.5-feat-add-tel-frontend-package.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.2.4...v9.2.5-feat-add-tel-frontend-package.1) (2025-04-22) ### Bug Fixes -* **add:** fff ([4ded49b](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/4ded49bdc79356256379a872b7754ab6929a5fea)) -* **dependabot:** fix ([3276815](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/3276815c8cb7c4250bcbfe39521b59f1286115f3)) -* **pr w:** lets ([7b990e9](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/7b990e90d32d26327fa40435df749c69b5be47f0)) - -## [9.2.4-feat-add-tel-frontend-package.2](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.2.4-feat-add-tel-frontend-package.1...v9.2.4-feat-add-tel-frontend-package.2) (2025-04-22) - - -### Bug Fixes - -* **add:** fff ([4ded49b](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/4ded49bdc79356256379a872b7754ab6929a5fea)) -* **pr w:** lets ([7b990e9](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/7b990e90d32d26327fa40435df749c69b5be47f0)) - -## [9.2.4-feat-add-tel-frontend-package.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.2.3...v9.2.4-feat-add-tel-frontend-package.1) (2025-04-22) - - -### Bug Fixes - -* **dependabot:** fix ([3276815](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/3276815c8cb7c4250bcbfe39521b59f1286115f3)) - -## [9.2.3](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.2.2...v9.2.3) (2025-04-22) - - -### Bug Fixes - -* **branch check:** inc dependabot ([80bec02](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/80bec025d50c733ee91f42ae318c65b19e5c7318)) +* **just qqqqs tidy up:** a chore really ([9800d0d](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/9800d0dcbda4fd175fe3931d811d1d9e4d7f69af)) +* **will it still work with ref:** try it ([af28fde](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/af28fde2ca18d74c1dd83eab5dd5995853f03020)) diff --git a/ReadMe.md b/ReadMe.md index 131f25b..f5cb274 100644 --- a/ReadMe.md +++ b/ReadMe.md @@ -1,6 +1,6 @@ # Good to know -A purpose is quick cicd. +The purpose is quick cicd. You can change your version of your package in the centralised solution and it will be picked up in consuming projects. You can optionally use a project reference for faster development by setting a flag. A build number could be automated into package names, the package already is automatically created on build. @@ -99,14 +99,46 @@ builds projects not a whole solution build. #### Pull request - just some checks they can be run even if they fail to see if there are multiple errors. They only show temporarily in the pr ui section of the git pull request but can be seen in actions. +They have been added in the branch rules which runs jobs selected from existing pipelines. This should add them to the list of checks. #### Release - similar to dev but without tests as these have already happened and no feature name in package, and the gh-page is released on this repo. +## local development +- use project reference +- or + - in local packages increase bcl version + - build the package + - run TestHostPrerenderWASM (not client) ## Notes Also DevServer needed adding to .client +NPM is not centralised like nuget because only using for just the TEL package css + +### Branch naming and commit naming see realserc + +feat: A new feature +fix: A bug fix +docs: Documentation only changes +style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) +refactor: A code change that neither fixes a bug nor adds a feature +perf: A code change that improves performance +test: Adding missing or correcting existing tests +chore: Changes to the build process or auxiliary tools and libraries such as documentation generation + +### Refs +[How to make 404 redirect for spa behaviour](https://blog.elmah.io/blazor-wasm-404-error-and-fix-for-github-pages/) +[git nektos act](https://github.com/nektos/act) +[nektos](https://nektosact.com/) + - [Confluence gitguardian](https://hee-tis.atlassian.net/wiki/spaces/TP/pages/3855253505/GitGuardian+Setup+-+Simplified+Version) + - [Confluence gitguardian extra](https://hee-tis.atlassian.net/wiki/spaces/TP/pages/3849289743/Secrete+Detection+-+GitGuardian+Setup+Extensive+Version) + + +# Outstanding +- git checks off branch rules and pull request yml seem not to be triggering +- auto merge pr doesnt seem to trigger atm +- some of the local variable set bools like for using project references are disabled # Future Recommendation @@ -114,6 +146,8 @@ There are options for making packing the blazor more efficient, as in smaller fo The would be worth exploring there are recommendations in the build tasks when the pipeline runs, also mudblazor is open and any process they have is worth considering. +Use hooks for gitguardian and commitlint + # Where to see the site diff --git a/SharedPages/SharedPages.csproj b/SharedPages/SharedPages.csproj index 16b037c..2e93fa6 100644 --- a/SharedPages/SharedPages.csproj +++ b/SharedPages/SharedPages.csproj @@ -5,14 +5,6 @@ enable enable - - - @@ -23,7 +15,7 @@ - + + + diff --git a/SharedPages/wwwroot/css/app.css b/SharedPages/wwwroot/css/app.css index 86aad4e..4b707f9 100644 --- a/SharedPages/wwwroot/css/app.css +++ b/SharedPages/wwwroot/css/app.css @@ -77,7 +77,6 @@ code { } .shared-pages-red-text { color: red; - /*qqqq test*/ } /* RCL Styles remember bundled scoped css we may not use it but it is extremely normal to so we may in future*/ @import '_content/Package.BlazorComponentLibrary/Package.BlazorComponentLibrary.bundle.scp.css'; \ No newline at end of file