Merge pull request #253 from TechnologyEnhancedLearning/TD-6335-Updated-Myaccount

AnjuJose011 · web-flow · commit 1eeac287c454 · 2025-10-13T09:15:54.000+01:00
TD-6335-Users are exploiting the certificate generation system on elfh and Learning Hub by changing account names to reproduce certificates under multiple identities.
diff --git a/LearningHub.Nhs.UserApi.Services/ElfhUserService.cs b/LearningHub.Nhs.UserApi.Services/ElfhUserService.cs
@@ -977,8 +977,6 @@ public async Task<bool> CheckSamePrimaryemailIsPendingToValidate(string secondar
         public async Task UpdateMyAccountPersonalDetails(PersonalDetailsViewModel personalDetailsViewModel, int currentUserId)
         {
             User user = await this.elfhUserRepository.GetByIdAsync(personalDetailsViewModel.UserId);
-            user.FirstName = personalDetailsViewModel.FirstName;
-            user.LastName = personalDetailsViewModel.LastName;
             user.PreferredName = personalDetailsViewModel.PreferredName;
             user.AltEmailAddress = personalDetailsViewModel.SecondaryEmailAddress;
 

Original file line number	Diff line number	Diff line change
`@@ -977,8 +977,6 @@ public async Task<bool> CheckSamePrimaryemailIsPendingToValidate(string secondar`
`977`	`977`	`public async Task UpdateMyAccountPersonalDetails(PersonalDetailsViewModel personalDetailsViewModel, int currentUserId)`
`978`	`978`	`{`
`979`	`979`	`User user = await this.elfhUserRepository.GetByIdAsync(personalDetailsViewModel.UserId);`
`980`		`- user.FirstName = personalDetailsViewModel.FirstName;`
`981`		`- user.LastName = personalDetailsViewModel.LastName;`
`982`	`980`	`user.PreferredName = personalDetailsViewModel.PreferredName;`
`983`	`981`	`user.AltEmailAddress = personalDetailsViewModel.SecondaryEmailAddress;`
`984`	`982`