diff --git a/.github/workflows/continuous-integration-workflow.yml b/.github/workflows/continuous-integration-workflow.yml index c0e0da4..e2a5e18 100644 --- a/.github/workflows/continuous-integration-workflow.yml +++ b/.github/workflows/continuous-integration-workflow.yml @@ -26,17 +26,17 @@ jobs: - name: Use Node 12.19 uses: actions/setup-node@v4 with: - node-version: '12.19' - + node-version: '18' + - name: Install dependencies run: | cd ./Auth/LearningHub.Nhs.Auth - npm install -f + yarn install - name: Run Webpack build run: | cd ./Auth/LearningHub.Nhs.Auth - npm run build + yarn build:webpack - name: Setup MSBuild uses: microsoft/setup-msbuild@v1.0.3 diff --git a/Auth/LearningHub.Nhs.Auth/Controllers/AccountController.cs b/Auth/LearningHub.Nhs.Auth/Controllers/AccountController.cs index 7764ad8..ff7b352 100644 --- a/Auth/LearningHub.Nhs.Auth/Controllers/AccountController.cs +++ b/Auth/LearningHub.Nhs.Auth/Controllers/AccountController.cs @@ -427,6 +427,7 @@ private async Task BuildLoginViewModelAsync(LoginInputModel mode { var vm = await this.BuildLoginViewModelAsync(model.ReturnUrl); vm.Username = model.Username; + vm.Password = model.Password; vm.RememberLogin = model.RememberLogin; return vm; } diff --git a/Auth/LearningHub.Nhs.Auth/LearningHub.Nhs.Auth.csproj b/Auth/LearningHub.Nhs.Auth/LearningHub.Nhs.Auth.csproj index ed914bc..4e2855c 100644 --- a/Auth/LearningHub.Nhs.Auth/LearningHub.Nhs.Auth.csproj +++ b/Auth/LearningHub.Nhs.Auth/LearningHub.Nhs.Auth.csproj @@ -112,7 +112,7 @@ - + all diff --git a/Auth/LearningHub.Nhs.Auth/Views/Account/LHLogin.cshtml b/Auth/LearningHub.Nhs.Auth/Views/Account/LHLogin.cshtml index 3aae2e5..91393ed 100644 --- a/Auth/LearningHub.Nhs.Auth/Views/Account/LHLogin.cshtml +++ b/Auth/LearningHub.Nhs.Auth/Views/Account/LHLogin.cshtml @@ -2,6 +2,7 @@ @{ ViewData["Title"] = "Login"; ViewData["Layout"] = "learninghub/_Layout"; + ViewData["DisableValidation"] = true; // OpenAthens url needs to makes sure that the return to WebUI first hits the authorisationrequired endpoint, // which contains it's own redirect to within the UI. // If a return url is specified we want to use it for the authorisationrequired original url @@ -54,7 +55,7 @@
@@ -54,12 +54,12 @@ id="@Model.DayId" name="@Model.DayId" value="@Model.DayValue" - type="number" - pattern="[0-9]*" + type="text" min="1" max="31" step="1" - inputmode="numeric" /> + inputmode="numeric" + aria-describedby="date-error" aria-invalid="false" />
@@ -69,12 +69,12 @@ id="@Model.MonthId" name="@Model.MonthId" value="@Model.MonthValue" - type="number" - pattern="[0-9]*" + type="text" min="1" max="12" step="1" - inputmode="numeric" /> + inputmode="numeric" + aria-describedby="date-error" aria-invalid="false" />
@@ -84,12 +84,12 @@ id="@Model.YearId" name="@Model.YearId" value="@Model.YearValue" - type="number" - pattern="[0-9]*" + type="text" min="1900" max="9999" step="1" - inputmode="numeric" /> + inputmode="numeric" + aria-describedby="date-error" aria-invalid="false" />
diff --git a/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/ErrorSummary/Default.cshtml b/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/ErrorSummary/Default.cshtml index 269b174..7f438d5 100644 --- a/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/ErrorSummary/Default.cshtml +++ b/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/ErrorSummary/Default.cshtml @@ -21,6 +21,10 @@ + } else { diff --git a/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/RadioList/Default.cshtml b/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/RadioList/Default.cshtml index 05eb266..eddfb33 100644 --- a/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/RadioList/Default.cshtml +++ b/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/RadioList/Default.cshtml @@ -9,7 +9,7 @@
-
+
@if (Model.IsPageHeading.GetValueOrDefault() == true) { @@ -44,7 +44,7 @@ @if (Model.Required && !Model.HasError) { -
+ } @@ -131,5 +131,4 @@
-
\ No newline at end of file diff --git a/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/TextInput/Default.cshtml b/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/TextInput/Default.cshtml index de13d0c..4cbdda0 100644 --- a/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/TextInput/Default.cshtml +++ b/Auth/LearningHub.Nhs.Auth/Views/Shared/Components/TextInput/Default.cshtml @@ -2,8 +2,8 @@ @using NHSUKViewComponents.Web.Helpers @model TextInputViewModel
-