Skip to content

Commit 067d659

Browse files
Merge pull request #328 from TechnologyEnhancedLearning/Develop/Fixes/TD-4108-Certificate-missing-for-the-few-of-the-completed-resources-on-My-Learning-page
TD-4108: Certificate issue for assessment and audio/video has been resolved
2 parents 1b3eafd + 4c0dfc6 commit 067d659

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

WebAPI/LearningHub.Nhs.Services/MyLearningService.cs

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -263,23 +263,16 @@ public async Task<List<MyLearningDetailedItemViewModel>> PopulateMyLearningDetai
263263
ResourceActivity expectedActivity = null;
264264
if (resourceActivity.Resource.ResourceTypeEnum == ResourceTypeEnum.Audio || resourceActivity.Resource.ResourceTypeEnum == ResourceTypeEnum.Video)
265265
{
266-
expectedActivity = latestActivityCheck.Where(x => x.Id == resourceActivity.Id && x.MediaResourceActivity != null && x.MediaResourceActivity.Any(x => x.PercentComplete == 100)).OrderByDescending(x => x.ActivityStart).FirstOrDefault();
266+
expectedActivity = latestActivityCheck.Where(x => x.LaunchResourceActivityId == resourceActivity.Id && resourceActivity.MediaResourceActivity != null && resourceActivity.MediaResourceActivity.Any(y => y.PercentComplete == 100)).OrderByDescending(y => y.ActivityStart).FirstOrDefault();
267267
}
268268
else
269269
{
270-
expectedActivity = latestActivityCheck.Where(x => x.Id == resourceActivity.Id && (x.ActivityStatusId == ((int)ActivityStatusEnum.Completed) || x.ActivityStatusId == ((int)ActivityStatusEnum.Launched) || x.ActivityStatusId == ((int)ActivityStatusEnum.Passed) || x.ActivityStatusId == ((int)ActivityStatusEnum.Downloaded))).OrderByDescending(x => x.ActivityStart).FirstOrDefault();
270+
expectedActivity = latestActivityCheck.Where(x => x.LaunchResourceActivityId == resourceActivity.Id && (x.ActivityStatusId == ((int)ActivityStatusEnum.Completed) || x.ActivityStatusId == ((int)ActivityStatusEnum.Launched) || x.ActivityStatusId == ((int)ActivityStatusEnum.Passed) || x.ActivityStatusId == ((int)ActivityStatusEnum.Downloaded))).OrderByDescending(x => x.ActivityStart).FirstOrDefault();
271271
}
272272

273-
if (latestActivityCheck.Any() && expectedActivity != null)
273+
if (latestActivityCheck.Any() && expectedActivity != null && resourceActivity.ResourceVersion.CertificateEnabled == true)
274274
{
275-
if (latestActivityCheck.OrderByDescending(x => x.ActivityStart).FirstOrDefault().Id == expectedActivity.Id)
276-
{
277-
viewModel.CertificateEnabled = resourceActivity.ResourceVersion.CertificateEnabled.GetValueOrDefault(false);
278-
}
279-
else
280-
{
281-
viewModel.CertificateEnabled = false;
282-
}
275+
viewModel.CertificateEnabled = true;
283276
}
284277
else
285278
{

0 commit comments

Comments
 (0)