Merge pull request #1475 from TechnologyEnhancedLearning/Develop/Fixes/CataloguePermissionfix

AnjuJose011 · web-flow · commit 0e91c4a4d85b · 2025-10-09T14:22:26.000+01:00
My Contribution Permission
diff --git a/OpenAPI/LearningHub.Nhs.OpenApi.Services/Services/UserGroupService.cs b/OpenAPI/LearningHub.Nhs.OpenApi.Services/Services/UserGroupService.cs
@@ -107,7 +107,7 @@ public async Task<UserGroup> GetByIdAsync(int id, bool includeRoles)
         public async Task<bool> UserHasCatalogueContributionPermission(int userId)
         {
             var userRoleGroups = await this.roleUserGroupRepository.GetRoleUserGroupViewModelsByUserId(userId);
-            if (userRoleGroups != null && userRoleGroups.Any(r => r.RoleEnum == RoleEnum.LocalAdmin || r.RoleEnum == RoleEnum.Editor))
+            if (userRoleGroups != null && userRoleGroups.Any(r => r.RoleEnum == RoleEnum.Editor))
             {
                 return true;
             }

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ public async Task<UserGroup> GetByIdAsync(int id, bool includeRoles)`
`107`	`107`	`public async Task<bool> UserHasCatalogueContributionPermission(int userId)`
`108`	`108`	`{`
`109`	`109`	`var userRoleGroups = await this.roleUserGroupRepository.GetRoleUserGroupViewModelsByUserId(userId);`
`110`		`- if (userRoleGroups != null && userRoleGroups.Any(r => r.RoleEnum == RoleEnum.LocalAdmin \|\| r.RoleEnum == RoleEnum.Editor))`
	`110`	`+ if (userRoleGroups != null && userRoleGroups.Any(r => r.RoleEnum == RoleEnum.Editor))`
`111`	`111`	`{`
`112`	`112`	`return true;`
`113`	`113`	`}`