Merge pull request #768 from TechnologyEnhancedLearning/TD-4182-ErrorDescription

TD-4182-Error suggestion is not clear

Author: AnjuJose011

LearningHub.Nhs.WebUI/Controllers/AccountController.cs

@@ -656,6 +656,7 @@ public async Task<IActionResult> CreateAccountProfessionalRegNumber(AccountCreat
         /// </summary>
         /// <returns>The <see cref="IActionResult"/>.</returns>
         /// <param name="accountCreationViewModel">accountCreationViewModel.</param>
+        [HttpPost]
         [Route("Registration/CreateAccountGradeSelection")]
         [ResponseCache(CacheProfileName = "Never")]
         [TypeFilter(typeof(RedirectMissingMultiPageFormData), Arguments = new object[] { nameof(MultiPageFormDataFeature.AddRegistrationPrompt) })]
@@ -672,7 +673,7 @@ public async Task<IActionResult> CreateAccountGradeSelection(AccountCreationView
 
             if (string.IsNullOrWhiteSpace(accountCreationViewModel.RegistrationNumber) && accountCreation.MedicalCouncilId.HasValue && (int)accountCreation.MedicalCouncilId > 0)
             {
-                this.ModelState.AddModelError("RegistrationNumber", $"You must provide a {accountCreation.MedicalCouncilCode} Number");
+                this.ModelState.AddModelError("RegistrationNumber", $"{accountCreation.MedicalCouncilName} Number is required");
                 this.ViewBag.Job = await this.jobRoleService.GetByIdAsync(roleId);
                 accountCreationViewModel.CurrentRole = roleId.ToString();
                 return this.View("CreateAccountProfessionalRegNumber", accountCreationViewModel);

LearningHub.Nhs.WebUI/Views/Account/CreateAccountProfessionalRegNumber.cshtml

@@ -21,7 +21,7 @@
                 <h1 class="nhsuk-heading-xl">Enter your @jobDetails.MedicalCouncilCode number</h1>
 
 
-                <form asp-controller="Account" asp-action="CreateAccountGradeSelection" method="get">
+                <form asp-controller="Account" asp-action="CreateAccountGradeSelection" method="post">
                     <input type="hidden" name="formSubmission" value="true">
                     @if (errorHasOccurred)
                     {
@@ -52,9 +52,7 @@
                                    hint-text=""
                                    autocomplete=""
                                    css-class="nhsuk-u-width-one-half"
-                                   required="true"
-                                   required-client-side-error-message="@jobDetails.MedicalCouncilName Number is required" />
-
+                                   required="false"/>
 
                     <div class="nhsuk-form-group">
                         <button type="submit" class="nhsuk-button">Continue</button>